-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace MSSQL driver with a better maintained version #30390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…go-mssqldb because it has more maintain
lunny
added
the
topic/build
PR changes how Gitea is built, i.e. regarding Docker or the Makefile
label
Apr 10, 2024
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Apr 10, 2024
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Apr 10, 2024
github-actions
bot
added
modifies/go
Pull requests that update Go code
modifies/dependencies
labels
Apr 10, 2024
silverwind
approved these changes
Apr 10, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Apr 10, 2024
yardenshoham
approved these changes
Apr 10, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Apr 10, 2024
delvh
changed the title
Use github.com/microsoft/go-mssqldb instead of github.com/denisenkom/go-mssqldb because it has more maintain
Replace MSSQL driver with a better maintained version
Apr 10, 2024
delvh
approved these changes
Apr 10, 2024
silverwind
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Apr 11, 2024
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Apr 11, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 11, 2024
* giteaofficial/main: Upgrade golangci-lint to v1.57.2 (go-gitea#30401) Replace MSSQL driver with a better maintained version (go-gitea#30390) [skip ci] Updated translations via Crowdin Minor color tweaks (go-gitea#30397) Use raw Wiki links for non-renderable Wiki files (go-gitea#30273) Various improvements for long file and commit names (go-gitea#30374)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/dependencies
modifies/go
Pull requests that update Go code
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
topic/build
PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the latest tag of
github.com/denisenkom/go-mssqldb
is in 2022, but as a fork of it,github.com/microsoft/go-mssqldb
has more activities than the original repository. We can convert the driver to the fork.Since the interface of Go database driver are the same, it should have no any affect for the end users.