Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace MSSQL driver with a better maintained version #30390

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 10, 2024

As the latest tag of github.com/denisenkom/go-mssqldb is in 2022, but as a fork of it, github.com/microsoft/go-mssqldb has more activities than the original repository. We can convert the driver to the fork.

Since the interface of Go database driver are the same, it should have no any affect for the end users.

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Apr 10, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 10, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 10, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/dependencies labels Apr 10, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 10, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 10, 2024
@delvh delvh changed the title Use github.com/microsoft/go-mssqldb instead of github.com/denisenkom/go-mssqldb because it has more maintain Replace MSSQL driver with a better maintained version Apr 10, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 11, 2024
@silverwind silverwind enabled auto-merge (squash) April 11, 2024 00:46
@silverwind silverwind merged commit f0bfad2 into go-gitea:main Apr 11, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 11, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 11, 2024
@lunny lunny deleted the lunny/sql_server_driver branch April 11, 2024 01:32
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 11, 2024
* giteaofficial/main:
  Upgrade golangci-lint to v1.57.2 (go-gitea#30401)
  Replace MSSQL driver with a better maintained version (go-gitea#30390)
  [skip ci] Updated translations via Crowdin
  Minor color tweaks (go-gitea#30397)
  Use raw Wiki links for non-renderable Wiki files (go-gitea#30273)
  Various improvements for long file and commit names (go-gitea#30374)
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants