Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkboxes on mobile view, remove some dead css (#30308) #30319

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Apr 7, 2024

Backport #30308 by @silverwind

Fix the checkbox issues in #30303 which were existing problems with these selectors, but made visible with #30162.

There is a lot of dead/useless CSS in form.css, I only fixed the two problems and remove CSS that was definitely not in use or needed.

Screenshot 2024-04-06 at 18 00 08 Screenshot 2024-04-06 at 18 00 28

Fix the checkbox issues in
go-gitea#30303 which were existing
problems with these selectors, but made visible with
go-gitea#30162.

There is a lot of dead/useless CSS in `form.css`, I only fixed the two
problems and remove CSS that was definitely not in use or needed.

<img width="369" alt="Screenshot 2024-04-06 at 18 00 08"
src="https://github.com/go-gitea/gitea/assets/115237/720f178b-1b22-48d4-8704-becb8ce66129">
<img width="405" alt="Screenshot 2024-04-06 at 18 00 28"
src="https://github.com/go-gitea/gitea/assets/115237/61c0f8ec-34af-46c5-a3fa-7c5c4d30c7d2">

Co-authored-by: Giteabot <[email protected]>
@GiteaBot GiteaBot requested review from delvh, lafriks and lunny April 7, 2024 12:36
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 7, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Apr 7, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 7, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 7, 2024
@silverwind silverwind enabled auto-merge (squash) April 7, 2024 12:38
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 7, 2024
@silverwind silverwind merged commit d26ec5f into go-gitea:release/v1.22 Apr 7, 2024
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants