Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit-Dropdown: Show Author of commit if available #30272

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Commit-Dropdown: Show Author of commit if available #30272

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c8fb09
Show Author of commit if available
sebastian-sauer Apr 3, 2024
924ce31
Merge branch 'main' into bugfix/29588_show_author_if_available
GiteaBot Apr 4, 2024
895ec13
Merge branch 'main' into bugfix/29588_show_author_if_available
GiteaBot Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions services/pull/pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,12 +989,12 @@ func GetPullCommits(ctx *gitea_context.Context, issue *issues_model.Issue) ([]Co
for _, commit := range prInfo.Commits {
var committerOrAuthorName string
var commitTime time.Time
if commit.Committer != nil {
committerOrAuthorName = commit.Committer.Name
commitTime = commit.Committer.When
} else {
if commit.Author != nil {
committerOrAuthorName = commit.Author.Name
commitTime = commit.Author.When
} else {
committerOrAuthorName = commit.Committer.Name
commitTime = commit.Committer.When
}

commits = append(commits, CommitInfo{
Expand Down