Remove fomantic checkbox module (#30162) #30168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSS is pretty slim already and the `.ui.toggle.checkbox` sliders on admin page also still work. The only necessary JS is the one that links `input` and `label` so that it can be toggled via label. All checkboxes except the markdown ones render at `--checkbox-size: 16px` now. <img width="174" alt="Screenshot 2024-03-28 at 22 15 10" src="https://github.com/go-gitea/gitea/assets/115237/3455c1bb-166b-47e4-9847-2d20dd1f04db"> <img width="499" alt="Screenshot 2024-03-28 at 21 00 07" src="https://github.com/go-gitea/gitea/assets/115237/412be2b3-d5a0-478a-b17b-43e6bc12e8ce"> <img width="83" alt="Screenshot 2024-03-28 at 22 14 34" src="https://github.com/go-gitea/gitea/assets/115237/d8c89838-a420-4723-8c49-89405bb39474"> --------- Co-authored-by: delvh <[email protected]>
GiteaBot
added
modifies/docs
modifies/frontend
modifies/js
modifies/templates
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XXL
|
I would suggest to re-consider it: #30165 (comment) |
|
per #30165 (comment) |
silverwind
approved these changes
Mar 29, 2024
GiteaBot
added
lgtm/need 1
|
I think this is a neccesary enhancement 😆. #30165 (comment) can skip. |
wxiaoguang
approved these changes
Mar 29, 2024
GiteaBot
added
lgtm/done
|
I will give it another special round of testing before merging this. I still think it's rather unnecessary to do it because 1.22 release is still a while off and we have plenty of time to catch issues. |
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Mar 29, 2024
GiteaBot
removed
the
lgtm/need 1
GiteaBot
added
the
lgtm/done
|
Can't find anything wrong, let's merge. |
silverwind
added
the
reviewed/wait-merge
|
@techknowlogick can you adjust the "required checks" config for |
Done. |
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #30162 by @silverwind
CSS is pretty slim already and the
.ui.toggle.checkboxsliders on admin page also still work. The only necessary JS is the one that linksinputandlabelso that it can be toggled via label. All checkboxes except the markdown ones render at--checkbox-size: 16pxnow.