Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in rerunning jobs (#29955) #29983

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Fix bugs in rerunning jobs (#29955) #29983

merged 2 commits into from
Mar 22, 2024

Commits on Mar 22, 2024

  1. Fix bugs in rerunning jobs (go-gitea#29955) 

    Fix go-gitea#28761
Fix go-gitea#27884
Fix go-gitea#28093

## Changes

### Rerun all jobs
When rerun all jobs, status of the jobs with `needs` will be set to
`blocked` instead of `waiting`. Therefore, these jobs will not run until
the required jobs are completed.

### Rerun a single job
When a single job is rerun, its dependents should also be rerun, just
like GitHub does
(go-gitea#28761 (comment)).
In this case, only the specified job will be set to `waiting`, its
dependents will be set to `blocked` to wait the job.

### Show warning if every job has `needs`
If every job in a workflow has `needs`, all jobs will be blocked and no
job can be run. So I add a warning message.

<img
src="https://github.com/go-gitea/gitea/assets/15528715/88f43511-2360-465d-be96-ee92b57ff67b"
width="480px" />
    @Zettat123 @GiteaBot
    Zettat123 authored and GiteaBot committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    5e58639 View commit details
    Browse the repository at this point in the history

  2. Update routers/web/repo/actions/actions.go 

    Co-authored-by: Zettat123 <[email protected]>
    @lunny @Zettat123
    lunny and Zettat123 authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    4132eb8 View commit details
    Browse the repository at this point in the history