Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert visibility to number #29226

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Convert visibility to number #29226

merged 2 commits into from
Feb 18, 2024

Conversation

zokkis
Copy link
Contributor

@zokkis zokkis commented Feb 17, 2024

Don't throw error while creating user (Fixes #29218)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 17, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 17, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Feb 17, 2024
@zokkis zokkis changed the title Fix: Use visibility as number Convert visibility to number Feb 17, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 18, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 18, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 18, 2024
@silverwind silverwind enabled auto-merge (squash) February 18, 2024 11:23
@silverwind silverwind merged commit 6093f50 into go-gitea:main Feb 18, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 18, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 18, 2024
@lunny lunny added the backport/v1.21 This PR should be backported to Gitea 1.21 label Feb 18, 2024
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.21. @zokkis, please send one manually. 🍵

go run ./contrib/backport 29226
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Feb 18, 2024
@zokkis zokkis deleted the fix/use-visibility-as-number branch February 18, 2024 17:13
@zokkis zokkis mentioned this pull request Feb 18, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Feb 19, 2024
@github-actions GitHub Actions
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

500 while creating users
6 participants
@zokkis @GiteaBot @KN4CK3R @wxiaoguang @lunny @silverwind