Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use repo as of renderctx's member rather than a repoPath on metas #29222

Merged
merged 18 commits into from
May 30, 2024
Merged

Use repo as of renderctx's member rather than a repoPath on metas #29222

merged 18 commits into from
May 30, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 17, 2024 •
edited
Loading

Use a gitrepo.Repository in the markup's RenderContext but not store the repository's path.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 17, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 17, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 17, 2024
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 19, 2024
@lunny lunny changed the title WIP: use repo as of renderctx's member rather than a repoPath on metas Use repo as of renderctx's member rather than a repoPath on metas Feb 22, 2024
@lunny lunny added this to the 1.22.0 milestone Feb 23, 2024
@lunny lunny mentioned this pull request Feb 27, 2024
Merged
@KN4CK3R KN4CK3R mentioned this pull request Feb 27, 2024
Merged
lunny pushed a commit that referenced this pull request Feb 29, 2024
@KN4CK3R
Fix wrong test usage of AppSubURL (#29459)
a6fd017 
The tests use an invalid `setting.AppSubURL`. The wrong behaviour
disturbs other PRs like #29222 and #29427.
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Feb 29, 2024
@KN4CK3R @GiteaBot
Fix wrong test usage of AppSubURL (go-gitea#29459)
90549e3 
The tests use an invalid `setting.AppSubURL`. The wrong behaviour
disturbs other PRs like go-gitea#29222 and go-gitea#29427.
@GiteaBot GiteaBot mentioned this pull request Feb 29, 2024
Merged
lunny pushed a commit that referenced this pull request Feb 29, 2024
@GiteaBot @KN4CK3R
Fix wrong test usage of AppSubURL (#29459) (#29488)
c293e34 
Backport #29459 by @KN4CK3R

The tests use an invalid `setting.AppSubURL`. The wrong behaviour
disturbs other PRs like #29222 and #29427.

Co-authored-by: KN4CK3R <[email protected]>
@lunny lunny mentioned this pull request Mar 2, 2024
Open
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 8, 2024
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Mar 8, 2024
@KN4CK3R @Gusted
Port "Fix wrong test usage of AppSubURL"
8f55cf1 
- Port of go-gitea/gitea#29459
- The tests use an invalid `setting.AppSubURL`. The wrong behaviour
disturbs other PRs like go-gitea/gitea#29222
and go-gitea/gitea#29427.
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 16, 2024
@lunny lunny modified the milestones: 1.22.0, 1.23.0 Mar 29, 2024
@yp05327 yp05327 self-requested a review April 17, 2024 12:16
yp05327
yp05327 reviewed May 29, 2024
View reviewed changes
modules/markup/markdown/markdown_test.go Outdated Show resolved Hide resolved
modules/markup/markdown/markdown_test.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 30, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 30, 2024
@lunny lunny enabled auto-merge (squash) May 30, 2024 06:35
@lunny lunny merged commit 015efcd into go-gitea:main May 30, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 30, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 30, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c74b94c 
* giteaofficial/main: (30 commits)
  Azure blob storage support (go-gitea#30995)
  Use repo as of renderctx's member rather than a repoPath on metas (go-gitea#29222)
  Ignore FindRecentlyPushedNewBranches err (go-gitea#31164)
  [skip ci] Updated translations via Crowdin
  Fix markup preview (go-gitea#31158)
  Swap word order in Comment and Close (go-gitea#31148)
  Fix push multiple branches error with tests (go-gitea#31151)
  Use vertical layout for multiple code expander buttons (go-gitea#31122)
  Remove duplicate `ProxyPreserveHost` in Apache httpd doc (go-gitea#31143)
  [skip ci] Updated translations via Crowdin
  Add an immutable tarball link to archive download headers for Nix (go-gitea#31139)
  Improve mobile review ui (go-gitea#31091)
  Add topics for repository API (go-gitea#31127)
  Add missed return after `ctx.ServerError` (go-gitea#31130)
  Fix API repository object format missed (go-gitea#31118)
  Fix DashboardRepoList margin (go-gitea#31121)
  Update JS dependencies (go-gitea#31120)
  [skip ci] Updated translations via Crowdin
  Prevent simultaneous editing of comments and issues (go-gitea#31053)
  Update demo site location from try.gitea.io -> demo.gitea.com (go-gitea#31054)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wolfogre wolfogre wolfogre approved these changes

@yp05327 yp05327 yp05327 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @wolfogre @yp05327 @GiteaBot