Refactor git version functions and check compatibility (#29155) #29157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
silverwind
reviewed
Feb 13, 2024
| c.env = append(c.env, "GIT_FLUSH=0") | ||
| } else { | ||
| c.env = append(c.env, "GIT_FLUSH=1") | ||
| } |
There was a problem hiding this comment.
Why is this part not in the main branch PR? Not needed there?
There was a problem hiding this comment.
I also think we do not need to do it in the main branch.
Maybe it's good to help some unlucky users in 1.21 branch (try the best to avoid "breaking" in a stable release)
silverwind
approved these changes
Feb 14, 2024
GiteaBot
added
lgtm/need 1
KN4CK3R
approved these changes
Feb 16, 2024
GiteaBot
added
lgtm/done
|
Automatically locked because of our CONTRIBUTING guidelines |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #29155 with an extra change: tolerate the git 2.43.1 GIT_FLUSH bug in Gitea 1.21.x, more details in the comment of repo_attribute.go
Manually tested with git 2.43.1 and an old git (2.39.2)