Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for #28765 #28773

Merged
merged 7 commits into from
Jan 12, 2024
Merged

Add tests for #28765 #28773

merged 7 commits into from
Jan 12, 2024

Conversation

jackHay22
Copy link
Contributor

Adds tests to cover changes made in #28765

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 12, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 12, 2024
@jackHay22 jackHay22 mentioned this pull request Jan 12, 2024
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 12, 2024
@lunny lunny added type/testing backport/v1.21 This PR should be backported to Gitea 1.21 labels Jan 12, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 12, 2024
KN4CK3R
KN4CK3R requested changes Jan 12, 2024
View reviewed changes
tests/integration/api_user_watch_test.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Jan 12, 2024
@yardenshoham yardenshoham self-requested a review January 12, 2024 15:08
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 12, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Jan 12, 2024
@KN4CK3R KN4CK3R added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 12, 2024
@lunny lunny enabled auto-merge (squash) January 12, 2024 17:10
@lunny lunny merged commit 6c68239 into go-gitea:main Jan 12, 2024
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Jan 12, 2024
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.21. @jackHay22, please send one manually. 🍵

go run ./contrib/backport 28773
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jan 12, 2024
jackHay22 added a commit to jackHay22/gitea that referenced this pull request Jan 12, 2024
@jackHay22
Add tests for go-gitea#28765 (go-gitea#28773)
243fbb8 
Backport go-gitea#28773

Adds tests to cover changes made in go-gitea#28765
@jackHay22
Copy link
Contributor Author

Manual backport for 1.21: #28778

fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@jackHay22 @fuxiaohei
Add tests for go-gitea#28765 (go-gitea#28773)
8d38d3f 
Adds tests to cover changes made in go-gitea#28765
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@jackHay22 @silverwind
Add tests for go-gitea#28765 (go-gitea#28773)
02f7d48 
Adds tests to cover changes made in go-gitea#28765
@lunny lunny added the backport/done All backports for this PR have been created label Feb 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@lunny lunny lunny approved these changes

@yardenshoham yardenshoham Awaiting requested review from yardenshoham

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/testing
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jackHay22 @GiteaBot @lunny @KN4CK3R @yardenshoham