Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the prompt for "ssh-keygen sign" #28509

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Improve the prompt for "ssh-keygen sign" #28509

merged 1 commit into from
Dec 18, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Dec 18, 2023 •
edited
Loading

@wxiaoguang wxiaoguang added the backport/v1.21 This PR should be backported to Gitea 1.21 label Dec 18, 2023
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Dec 18, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 18, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2023
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Dec 18, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 18, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 18, 2023
@lunny lunny merged commit bf8b082 into go-gitea:main Dec 18, 2023
25 checks passed
@GiteaBot GiteaBot mentioned this pull request Dec 18, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 18, 2023
@wxiaoguang @GiteaBot
Improve the prompt for "ssh-keygen sign" (go-gitea#28509)
1de37ce 
Close go-gitea#28505, ref:
* go-gitea#20112 (comment)
* go-gitea#28505 (comment)
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Dec 18, 2023
@wxiaoguang wxiaoguang deleted the fix-ssh-sign-verify branch December 18, 2023 14:59
wxiaoguang added a commit that referenced this pull request Dec 18, 2023
@GiteaBot @wxiaoguang
Improve the prompt for "ssh-keygen sign" (#28509) (#28510)
4462628 
Backport #28509 by wxiaoguang

Close #28505

Co-authored-by: wxiaoguang <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 19, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c919783 
* giteaofficial/main:
  Fix duplicate ID when deleting repo (go-gitea#28520)
  chore(api): support ignore password if login source type is LDAP for creating user API (go-gitea#28491)
  Update go dependencies (go-gitea#28518)
  Bump google/go-github to v57 (go-gitea#28514)
  Only check online runner when detecting matching runners in workflows (go-gitea#28286)
  Add orphaned topic consistency check (go-gitea#28507)
  Improve the prompt for "ssh-keygen sign" (go-gitea#28509)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@wxiaoguang @fuxiaohei
Improve the prompt for "ssh-keygen sign" (go-gitea#28509)
5fc73c2 
Close go-gitea#28505, ref:
* go-gitea#20112 (comment)
* go-gitea#28505 (comment)
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@wxiaoguang @silverwind
Improve the prompt for "ssh-keygen sign" (go-gitea#28509)
764b3b7 
Close go-gitea#28505, ref:
* go-gitea#20112 (comment)
* go-gitea#28505 (comment)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Passing the pubkey to ssh-keygen is sufficient to verify an SSH signing key
4 participants
@wxiaoguang @lunny @delvh @GiteaBot