Fix migration panic due to an empty review comment diff (#28334) #28362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #28334 by @lng2020
Fix #28328
This function in the package
go-github
may return an empty diff. When it's empty, the following code will panic because it accessss[1]
gitea/services/migrations/gitea_uploader.go
Lines 861 to 867 in ec1feed
gitea/modules/git/diff.go
Lines 97 to 101 in ec1feed