Refactor template empty checks #28351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KN4CK3R
added
type/bug
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
the
modifies/templates
delvh
reviewed
Dec 4, 2023
| {{template "repo/diff/conversation" dict "." $.root "comments" $line.Comments}} | ||
| {{end}} | ||
| {{if eq $line.GetCommentSide "previous"}} | ||
| {{template "repo/diff/conversation" dict "." $.root "comments" $line.Comments}} |
There was a problem hiding this comment.
Doesn't this panic when not $line.Comments?
There was a problem hiding this comment.
Removed the check because it is already in line 139.
delvh
approved these changes
Dec 4, 2023
GiteaBot
added
lgtm/need 1
jolheiser
approved these changes
Dec 4, 2023
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Dec 5, 2023
pangliang
pushed a commit
to pangliang/gitea
that referenced
this pull request
Dec 5, 2023
lunny
pushed a commit
that referenced
this pull request
Dec 5, 2023
Backport #28351 by @KN4CK3R Fix #28347 As there is no info how to reproduce it, I can't test it. Fix may be `section_split.tmpl @ 126/130`. Other changes are "empty check" refactorings. Co-authored-by: KN4CK3R <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 5, 2023
* giteaofficial/main: Convert git commit summary to valid UTF8. (go-gitea#28356) Fix RPM/Debian signature key creation (go-gitea#28352) Refactor template empty checks (go-gitea#28351)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #28347
As there is no info how to reproduce it, I can't test it.
Fix may be
section_split.tmpl @ 126/130.Other changes are "empty check" refactorings.