-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render PyPi long description as document #28272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PyPi long descriptions supports markdown and are rendered as such in Forgejo, however it uses `RenderMarkdownToHtml` function, which would render all newlines literally causing that lines seperated by newlines aren't rendered as a continues line. - Add a new helper function that renders markdown as a document and use it for PyPi's long description. - Resolves https://codeberg.org/forgejo/forgejo/issues/1784 (cherry picked from commit feaebc15793a9c74713e40c478872e3709dc09b6)
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Nov 28, 2023
pull-request-size
bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Nov 28, 2023
a1012112796
approved these changes
Nov 30, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Nov 30, 2023
I think it would be better to just change the existing |
pull-request-size
bot
added
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Dec 4, 2023
KN4CK3R
approved these changes
Dec 5, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Dec 5, 2023
jolheiser
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Dec 5, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Dec 5, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 6, 2023
* giteaofficial/main: Fix the runs will not be displayed bug when the main branch have no workflows but other branches have (go-gitea#28359) [skip ci] Updated translations via Crowdin Render PyPi long description as document (go-gitea#28272) handle repository.size column being NULL in migration v263 (go-gitea#28336) Fix migration panic due to an empty review comment diff (go-gitea#28334) Add `HEAD` support for rpm repo files (go-gitea#28309) Remove deprecated query condition in ListReleases (go-gitea#28339)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
Co-authored-by: Gusted <[email protected]>
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
Co-authored-by: Gusted <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
topic/packages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RenderMarkdownToHtml
function, which would render all newlines literally causing that lines seperated by newlines aren't rendered as a continues line.(cherry picked from commit feaebc15793a9c74713e40c478872e3709dc09b6)