Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add border to file tree 'sub-items' and add padding to 'item-file' #27593

Merged
merged 9 commits into from
Oct 25, 2023
Merged

Add border to file tree 'sub-items' and add padding to 'item-file' #27593

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5790b68
Add border to file tree 'sub-items' and add padding to 'item-file'
lng2020 Oct 12, 2023
b61d6d4
change padding
lng2020 Oct 12, 2023
141b885
Update web_src/js/components/DiffFileTreeItem.vue
lng2020 Oct 12, 2023
21328f6
fix conflicts
lng2020 Oct 22, 2023
8a7f825
fix padding
lng2020 Oct 22, 2023
c896812
change padding
lng2020 Oct 22, 2023
fbbf2f0
change padding
lng2020 Oct 22, 2023
cca6ee7
Merge branch 'main' into improve_file_tree
silverwind Oct 24, 2023
ed8b731
Merge branch 'main' into improve_file_tree
GiteaBot Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions web_src/js/components/DiffFileTreeItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,12 @@ a, a:hover {
display: flex;
flex-direction: column;
gap: 1px;
padding-left: 8px;
margin-left: 13px;
Copy link
Member Author

@lng2020 lng2020 Oct 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That value is due to some math work 😢

border-left: 1px solid var(--color-secondary);
lng2020 marked this conversation as resolved.
Show resolved Hide resolved
}

.sub-items .item-file {
padding-left: 24px;
padding-left: 18px;
Copy link
Member Author

@lng2020 lng2020 Oct 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one too 😢

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should document this math, otherwise it will break again and again…

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

certainly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do any particular math when changing these the last time, I just went with what looked okay.

}

.item-file.selected {
Expand Down