Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable production source maps for index.js, fix CSS sourcemaps (#27291) #27295

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #27291 by @silverwind

Previously, the production build never output sourcemaps. Now we emit one file for index.js because it is the most likely one where we need to be able to better debug reported issues like #27213. This will currently increase the binary size of gitea by around 700kB which is what the gzipped source map file has.

Also, I fixed the CSS sourcemap generation which was broken since the introduction of lightningcss.

The chinese docs are machine-translated, please correct accordingly.

…tea#27291)

Previously, the production build never output sourcemaps. Now we emit
one file for `index.js` because it is the most likely one where we need
to be able to better debug reported issues like
go-gitea#27213. This will currently
increase the binary size of gitea by around 700kB which is what the
gzipped source map file has.

Also, I fixed the CSS sourcemap generation which was broken since the
introduction of lightningcss.
@GiteaBot GiteaBot added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/docs This PR mainly updates/creates documentation labels Sep 27, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Sep 27, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 27, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 27, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 27, 2023
@lunny
Copy link
Member

lunny commented Sep 27, 2023

Please wait #27296

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 27, 2023
@silverwind silverwind merged commit 42f7c2a into go-gitea:release/v1.21 Sep 27, 2023
25 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants