Do not force creation of _cargo-index repo on publish #27266

merlleu · 2023-09-25T18:21:30Z

Hello there,
Cargo Index over HTTP is now prefered over git for package updates: we should not force users who do not need the GIT repo to have the repo created/updated on each publish (it can still be created in the packages settings).

The current behavior when publishing is to check if the repo exist and create it on the fly if not, then update it's content.
Cargo HTTP Index does not rely on the repo itself so this will be useless for everyone not using the git protocol for cargo registry.

This PR only disable the creation on the fly of the repo when publishing a crate.

This is linked to #26844 (error 500 when trying to publish a crate if user is missing write access to the repo) because it's now optional.

silverwind · 2023-09-25T19:03:31Z

I noticed in a instance of mine that a _cargo-index repo was created, even though I never published a cargo package (I did publish other packages though). Will this get rid of this creation?

merlleu · 2023-09-25T21:32:11Z

I noticed in a instance of mine that a _cargo-index repo was created, even though I never published a cargo package (I did publish other packages though). Will this get rid of this creation?

Hello, from what I understood only 3 actions can trigger the repo creation: cargo publish or use of the Settings > Packages > Initialize/Rebuild Index.
Are you sure you did not use the 2 last buttons ? Might be worth creating a separate issue including commit log and the logs around the commits if you did not.

silverwind · 2023-09-25T22:25:04Z

Ah, yes it might have been the Initialize/Rebuild Index button. Sorry, it's off-topic here :)

lunny · 2023-10-02T09:09:40Z

Could we know the protocol of the client side? maybe we should obey the client side protocol to do that. Sparse or not.
Or maybe we can retire old protocol entirely.

merlleu · 2023-10-02T20:38:07Z

Could we know the protocol of the client side? maybe we should obey the client side protocol to do that. Sparse or not. Or maybe we can retire old protocol entirely.

We can't know this this unfortunately, I think we should push users toward using exclusively httpregistry, maybe remove all instructions to setup git registry and make it optional, then disable it entirely in a future version ?

lunny · 2023-10-03T08:23:18Z

Could we know the protocol of the client side? maybe we should obey the client side protocol to do that. Sparse or not. Or maybe we can retire old protocol entirely.

We can't know this this unfortunately, I think we should push users toward using exclusively httpregistry, maybe remove all instructions to setup git registry and make it optional, then disable it entirely in a future version ?

I would like the idea. As this PR, maybe we can have an option to enable/disable git registry. Maybe the default value could be false. So spare protocol could be the default one but git registry is optional.

merlleu · 2023-10-03T12:41:35Z

Could we know the protocol of the client side? maybe we should obey the client side protocol to do that. Sparse or not. Or maybe we can retire old protocol entirely.

We can't know this this unfortunately, I think we should push users toward using exclusively httpregistry, maybe remove all instructions to setup git registry and make it optional, then disable it entirely in a future version ?

I would like the idea. As this PR, maybe we can have an option to enable/disable git registry. Maybe the default value could be false. So spare protocol could be the default one but git registry is optional.

I think this is basically what this PR does: users will have to click "Init Index" in the org/user package settings to have the registry enabled. They can just remove the repo if they no longer want to use git registry and it should not create it again.

Please note that the authorization support for the cargo registry just made it to the nightly branch (on the client) so there should not be too much gitea users using this package registry yet, so we can probably remove the git version before too much people start using it.

KN4CK3R

Could you change the method name from AddOrUpdatePackageIndex to just UpdatePackageIndex then? (or a better name? TryUpdatePackageIndex, UpdateExistingPackageIndex, ...?)

services/packages/cargo/index.go

Co-authored-by: KN4CK3R <[email protected]>

merlleu · 2023-10-08T20:11:47Z

Could you change the method name from AddOrUpdatePackageIndex to just UpdatePackageIndex then? (or a better name? TryUpdatePackageIndex, UpdateExistingPackageIndex, ...?)

Thanks for the feedback, I renamed it to UpdatePackageIndexIfExists.

Hello there, Cargo Index over HTTP is now prefered over git for package updates: we should not force users who do not need the GIT repo to have the repo created/updated on each publish (it can still be created in the packages settings). The current behavior when publishing is to check if the repo exist and create it on the fly if not, then update it's content. Cargo HTTP Index does not rely on the repo itself so this will be useless for everyone not using the git protocol for cargo registry. This PR only disable the creation on the fly of the repo when publishing a crate. This is linked to go-gitea#26844 (error 500 when trying to publish a crate if user is missing write access to the repo) because it's now optional. --------- Co-authored-by: KN4CK3R <[email protected]>

* giteaofficial/main: Do not force creation of _cargo-index repo on publish (go-gitea#27266) Upgrade to [email protected] (go-gitea#27756) Fix incorrect "tab" parameter for repo search sub-template (go-gitea#27755) Fix label render containing invalid HTML (go-gitea#27752) Fix duplicate project board when hitting `enter` key (go-gitea#27746) Fix `link-action` redirect network error (go-gitea#27734)

@merlleu

Backport #27266 by @merlleu Hello there, Cargo Index over HTTP is now prefered over git for package updates: we should not force users who do not need the GIT repo to have the repo created/updated on each publish (it can still be created in the packages settings). The current behavior when publishing is to check if the repo exist and create it on the fly if not, then update it's content. Cargo HTTP Index does not rely on the repo itself so this will be useless for everyone not using the git protocol for cargo registry. This PR only disable the creation on the fly of the repo when publishing a crate. This is linked to #26844 (error 500 when trying to publish a crate if user is missing write access to the repo) because it's now optional. Co-authored-by: merlleu <[email protected]> Co-authored-by: KN4CK3R <[email protected]>

Hello there, Cargo Index over HTTP is now prefered over git for package updates: we should not force users who do not need the GIT repo to have the repo created/updated on each publish (it can still be created in the packages settings). The current behavior when publishing is to check if the repo exist and create it on the fly if not, then update it's content. Cargo HTTP Index does not rely on the repo itself so this will be useless for everyone not using the git protocol for cargo registry. This PR only disable the creation on the fly of the repo when publishing a crate. This is linked to go-gitea#26844 (error 500 when trying to publish a crate if user is missing write access to the repo) because it's now optional. --------- Co-authored-by: KN4CK3R <[email protected]>

Do not force creation of repo on cargo publish

d68b204

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 25, 2023

pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 25, 2023

github-actions bot added the topic/packages label Sep 25, 2023

apply lint

a56c89f

lunny requested a review from KN4CK3R September 27, 2023 07:35

lunny added the backport/v1.21 This PR should be backported to Gitea 1.21 label Sep 27, 2023

lunny added this to the 1.22.0 milestone Sep 27, 2023

KN4CK3R reviewed Oct 8, 2023

View reviewed changes

services/packages/cargo/index.go Outdated Show resolved Hide resolved

merlleu and others added 2 commits October 8, 2023 22:03

Update services/packages/cargo/index.go

93b647d

Co-authored-by: KN4CK3R <[email protected]>

rename func

f9462e6

github-actions bot added the modifies/api This PR adds API routes or modifies them label Oct 8, 2023

lunny approved these changes Oct 9, 2023

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 9, 2023

wxiaoguang approved these changes Oct 24, 2023

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 24, 2023

lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 24, 2023

lunny enabled auto-merge (squash) October 24, 2023 01:43

GiteaBot added 2 commits October 24, 2023 09:43

Merge branch 'main' into cargo-http-only

e492973

Merge branch 'main' into cargo-http-only

a372974

Merge branch 'main' into cargo-http-only

341f63c

lunny merged commit 796ff26 into go-gitea:main Oct 24, 2023
25 checks passed

GiteaBot mentioned this pull request Oct 24, 2023

Do not force creation of _cargo-index repo on publish (#27266) #27765

Merged

GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 24, 2023

go-gitea locked as resolved and limited conversation to collaborators Jan 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not force creation of _cargo-index repo on publish #27266

Do not force creation of _cargo-index repo on publish #27266

merlleu commented Sep 25, 2023 •

edited

Loading

silverwind commented Sep 25, 2023 •

edited

Loading

merlleu commented Sep 25, 2023

silverwind commented Sep 25, 2023

lunny commented Oct 2, 2023

merlleu commented Oct 2, 2023

lunny commented Oct 3, 2023

merlleu commented Oct 3, 2023 •

edited

Loading

KN4CK3R left a comment

merlleu commented Oct 8, 2023

Do not force creation of _cargo-index repo on publish #27266

Do not force creation of _cargo-index repo on publish #27266

Conversation

merlleu commented Sep 25, 2023 • edited Loading

silverwind commented Sep 25, 2023 • edited Loading

merlleu commented Sep 25, 2023

silverwind commented Sep 25, 2023

lunny commented Oct 2, 2023

merlleu commented Oct 2, 2023

lunny commented Oct 3, 2023

merlleu commented Oct 3, 2023 • edited Loading

KN4CK3R left a comment

Choose a reason for hiding this comment

merlleu commented Oct 8, 2023

merlleu commented Sep 25, 2023 •

edited

Loading

silverwind commented Sep 25, 2023 •

edited

Loading

merlleu commented Oct 3, 2023 •

edited

Loading