Fix PushEvent NullPointerException jenkinsci/github-plugin #27203

Nabapadma-sarker · 2023-09-23T06:15:54Z

CaiCandong · 2023-09-23T06:31:35Z

services/convert/repository.go

 		HTMLURL:                       repo.HTMLURL(),
+		URL:                           repo.URL(),


What's the difference between calling repo.HTMLURL() and repo.URL()?

there is no difference. I made a new function for it if the repo.HTMLURL() function changed latter. remove it or keep?

Just reuse repo.HTMLURL

thanks for the suggestion, reused that.

CaiCandong · 2023-09-23T14:51:00Z

please run make generate-swagger to fix it

lunny · 2023-09-24T03:25:08Z

Could we change jenkinsci side to use html_url, it's a duplication.

Nabapadma-sarker · 2023-09-24T04:39:22Z

Could we change jenkinsci side to use html_url, it's a duplication.

https://docs.github.com/en/[email protected]/webhooks/webhook-events-and-payloads

"repository": {
    "id": 17273051,
    "node_id": "MDEwOlJlcG9zaXRvcnkxNzI3MzA1MQ==",
    "name": "octo-repo",
    "full_name": "octo-org/octo-repo",
    "private": true,
    "owner": {
      "login": "octo-org",
      "id": 6811672,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjY4MTE2NzI=",
      "avatar_url": "https://avatars.githubusercontent.com/u/6811672?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/octo-org",
      "html_url": "https://github.com/octo-org",
      "followers_url": "https://api.github.com/users/octo-org/followers",
      "following_url": "https://api.github.com/users/octo-org/following{/other_user}",
      "gists_url": "https://api.github.com/users/octo-org/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/octo-org/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/octo-org/subscriptions",
      "organizations_url": "https://api.github.com/users/octo-org/orgs",
      "repos_url": "https://api.github.com/users/octo-org/repos",
      "events_url": "https://api.github.com/users/octo-org/events{/privacy}",
      "received_events_url": "https://api.github.com/users/octo-org/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "html_url": "https://github.com/octo-org/octo-repo",
    "description": "My first repo on GitHub!",
    "fork": false,
    "url": "https://api.github.com/repos/octo-org/octo-repo",
    "forks_url": "https://api.github.com/repos/octo-org/octo-repo/forks",
    "keys_url": "https://api.github.com/repos/octo-org/octo-repo/keys{/key_id}",

here you can see github weebhook payload also using url, html_url for different context. I don't know what would be right url format though it's now resolved the null exception.

lunny · 2023-09-24T11:40:31Z

Could we change jenkinsci side to use html_url, it's a duplication.

https://docs.github.com/en/[email protected]/webhooks/webhook-events-and-payloads

"repository": {
    "id": 17273051,
    "node_id": "MDEwOlJlcG9zaXRvcnkxNzI3MzA1MQ==",
    "name": "octo-repo",
    "full_name": "octo-org/octo-repo",
    "private": true,
    "owner": {
      "login": "octo-org",
      "id": 6811672,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjY4MTE2NzI=",
      "avatar_url": "https://avatars.githubusercontent.com/u/6811672?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/octo-org",
      "html_url": "https://github.com/octo-org",
      "followers_url": "https://api.github.com/users/octo-org/followers",
      "following_url": "https://api.github.com/users/octo-org/following{/other_user}",
      "gists_url": "https://api.github.com/users/octo-org/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/octo-org/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/octo-org/subscriptions",
      "organizations_url": "https://api.github.com/users/octo-org/orgs",
      "repos_url": "https://api.github.com/users/octo-org/repos",
      "events_url": "https://api.github.com/users/octo-org/events{/privacy}",
      "received_events_url": "https://api.github.com/users/octo-org/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "html_url": "https://github.com/octo-org/octo-repo",
    "description": "My first repo on GitHub!",
    "fork": false,
    "url": "https://api.github.com/repos/octo-org/octo-repo",
    "forks_url": "https://api.github.com/repos/octo-org/octo-repo/forks",
    "keys_url": "https://api.github.com/repos/octo-org/octo-repo/keys{/key_id}",

here you can see github weebhook payload also using url, html_url for different context. I don't know what would be right url format though it's now resolved the null exception.

So url means APIURL, it's not the same as HTMLURL.

Nabapadma-sarker · 2023-09-24T12:55:21Z

Could we change jenkinsci side to use html_url, it's a duplication.

https://docs.github.com/en/[email protected]/webhooks/webhook-events-and-payloads

"repository": {
    "id": 17273051,
    "node_id": "MDEwOlJlcG9zaXRvcnkxNzI3MzA1MQ==",
    "name": "octo-repo",
    "full_name": "octo-org/octo-repo",
    "private": true,
    "owner": {
      "login": "octo-org",
      "id": 6811672,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjY4MTE2NzI=",
      "avatar_url": "https://avatars.githubusercontent.com/u/6811672?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/octo-org",
      "html_url": "https://github.com/octo-org",
      "followers_url": "https://api.github.com/users/octo-org/followers",
      "following_url": "https://api.github.com/users/octo-org/following{/other_user}",
      "gists_url": "https://api.github.com/users/octo-org/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/octo-org/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/octo-org/subscriptions",
      "organizations_url": "https://api.github.com/users/octo-org/orgs",
      "repos_url": "https://api.github.com/users/octo-org/repos",
      "events_url": "https://api.github.com/users/octo-org/events{/privacy}",
      "received_events_url": "https://api.github.com/users/octo-org/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "html_url": "https://github.com/octo-org/octo-repo",
    "description": "My first repo on GitHub!",
    "fork": false,
    "url": "https://api.github.com/repos/octo-org/octo-repo",
    "forks_url": "https://api.github.com/repos/octo-org/octo-repo/forks",
    "keys_url": "https://api.github.com/repos/octo-org/octo-repo/keys{/key_id}",

here you can see github weebhook payload also using url, html_url for different context. I don't know what would be right url format though it's now resolved the null exception.

So url means APIURL, it's not the same as HTMLURL.

I build again using APIURL
URL: repo.APIURL(),
that is also working with jenkins plugin. so do I need to change it to repo.APIURL() ?

lunny · 2023-09-24T13:11:01Z

Could we change jenkinsci side to use html_url, it's a duplication.

https://docs.github.com/en/[email protected]/webhooks/webhook-events-and-payloads

"repository": {
    "id": 17273051,
    "node_id": "MDEwOlJlcG9zaXRvcnkxNzI3MzA1MQ==",
    "name": "octo-repo",
    "full_name": "octo-org/octo-repo",
    "private": true,
    "owner": {
      "login": "octo-org",
      "id": 6811672,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjY4MTE2NzI=",
      "avatar_url": "https://avatars.githubusercontent.com/u/6811672?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/octo-org",
      "html_url": "https://github.com/octo-org",
      "followers_url": "https://api.github.com/users/octo-org/followers",
      "following_url": "https://api.github.com/users/octo-org/following{/other_user}",
      "gists_url": "https://api.github.com/users/octo-org/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/octo-org/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/octo-org/subscriptions",
      "organizations_url": "https://api.github.com/users/octo-org/orgs",
      "repos_url": "https://api.github.com/users/octo-org/repos",
      "events_url": "https://api.github.com/users/octo-org/events{/privacy}",
      "received_events_url": "https://api.github.com/users/octo-org/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "html_url": "https://github.com/octo-org/octo-repo",
    "description": "My first repo on GitHub!",
    "fork": false,
    "url": "https://api.github.com/repos/octo-org/octo-repo",
    "forks_url": "https://api.github.com/repos/octo-org/octo-repo/forks",
    "keys_url": "https://api.github.com/repos/octo-org/octo-repo/keys{/key_id}",

here you can see github weebhook payload also using url, html_url for different context. I don't know what would be right url format though it's now resolved the null exception.

So url means APIURL, it's not the same as HTMLURL.

I build again using APIURL URL: repo.APIURL(), that is also working with jenkins plugin. so do I need to change it to repo.APIURL() ?

Yes, please.

…27203) Fixes go-gitea#27202

@Nabapadma-sarker

…27249) Backport #27203 by @Nabapadma-sarker Fixes #27202 Co-authored-by: Nabapadma-sarker <[email protected]>

* giteaofficial/main: Add missing public user visibility in user details page (go-gitea#27246) Use mask-based fade-out effect for `.new-menu` (go-gitea#27181) [skip ci] Updated translations via Crowdin Fix z-index on markdown completion (go-gitea#27237) Update database-preparation and add note re: MariaDB (go-gitea#27232) cleanup locale function usage (go-gitea#27227) Fix EOL handling in web editor (go-gitea#27141) Fix PushEvent NullPointerException jenkinsci/github-plugin (go-gitea#27203) fix issues on action runners page (go-gitea#27226) Fix Fomantic UI dropdown icon bug when there is a search input in menu (go-gitea#27225) Update go-enry to 2.8.5 (go-gitea#27215) Update nodejs installation method in release container (go-gitea#27207) Quote table `release` in sql queries (go-gitea#27205) Fix push mirror, wrong timestamp format (go-gitea#27153) Allow copying issue comment link on archived repos and when not logged in (go-gitea#27193) fix: text decorator on issue sidebar menu label (go-gitea#27206) Update JS and Poetry dependencies and eslint (go-gitea#27200) Remove some dead code (go-gitea#27196) # Conflicts: # templates/repo/issue/view_content/context_menu.tmpl

GiteaBot · 2023-09-25T07:33:06Z

I was unable to create a backport for 1.20. @Nabapadma-sarker, please send one manually. 🍵

go run ./contrib/backport 27203
...  // fix git conflicts if any
go run ./contrib/backport --continue

@Nabapadma-sarker

…27251) Backport #27203 by @Nabapadma-sarker Fixes #27202 Co-authored-by: Nabapadma-sarker <[email protected]>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.io/gitea/gitea](https://github.com/go-gitea/gitea) | patch | `1.20.4` -> `1.20.5` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the logs for more information. --- ### Release Notes <details> <summary>go-gitea/gitea (docker.io/gitea/gitea)</summary> ### [`v1.20.5`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1205---2023-10-03) [Compare Source](go-gitea/gitea@v1.20.4...v1.20.5) - ENHANCEMENTS - Fix z-index on markdown completion ([#27237](go-gitea/gitea#27237)) ([#27242](go-gitea/gitea#27242) & [#27238](go-gitea/gitea#27238)) - Use secure cookie for HTTPS sites ([#26999](go-gitea/gitea#26999)) ([#27013](go-gitea/gitea#27013)) - BUGFIXES - Fix git 2.11 error when checking IsEmpty ([#27393](go-gitea/gitea#27393)) ([#27396](go-gitea/gitea#27396)) - Allow get release download files and lfs files with oauth2 token format ([#26430](go-gitea/gitea#26430)) ([#27378](go-gitea/gitea#27378)) - Fix orphan check for deleted branch ([#27310](go-gitea/gitea#27310)) ([#27320](go-gitea/gitea#27320)) - Quote table `release` in sql queries ([#27205](go-gitea/gitea#27205)) ([#27219](go-gitea/gitea#27219)) - Fix release URL in webhooks ([#27182](go-gitea/gitea#27182)) ([#27184](go-gitea/gitea#27184)) - Fix successful return value for `SyncAndGetUserSpecificDiff` ([#27152](go-gitea/gitea#27152)) ([#27156](go-gitea/gitea#27156)) - fix pagination for followers and following ([#27127](go-gitea/gitea#27127)) ([#27138](go-gitea/gitea#27138)) - Fix issue templates when blank isses are disabled ([#27061](go-gitea/gitea#27061)) ([#27082](go-gitea/gitea#27082)) - Fix context cache bug & enable context cache for dashabord commits' authors([#26991](go-gitea/gitea#26991)) ([#27017](go-gitea/gitea#27017)) - Fix INI parsing for value with trailing slash ([#26995](go-gitea/gitea#26995)) ([#27001](go-gitea/gitea#27001)) - Fix PushEvent NullPointerException jenkinsci/github-plugin ([#27203](go-gitea/gitea#27203)) ([#27249](go-gitea/gitea#27249)) - Fix organization field being null in POST /orgs/{orgid}/teams ([#27150](go-gitea/gitea#27150)) ([#27167](go-gitea/gitea#27167) & [#27162](go-gitea/gitea#27162)) - Fix bug of review request number ([#27406](go-gitea/gitea#27406)) ([#27104](go-gitea/gitea#27104)) - TESTING - services/wiki: Close() after error handling ([#27129](go-gitea/gitea#27129)) ([#27137](go-gitea/gitea#27137)) - DOCS - Improve actions docs related to `pull_request` event ([#27126](go-gitea/gitea#27126)) ([#27145](go-gitea/gitea#27145)) - MISC - Add logs for data broken of comment review ([#27326](go-gitea/gitea#27326)) ([#27344](go-gitea/gitea#27344)) - Load reviewer before sending notification ([#27063](go-gitea/gitea#27063)) ([#27064](go-gitea/gitea#27064)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.home/nrdufour/home-ops/pulls/129 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>

new url variable added to Repository struct

93736d8

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 23, 2023

pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2023

CaiCandong reviewed Sep 23, 2023

View reviewed changes

repeted function removed.

c91b5f8

swagger updated.

70004f3

github-actions bot added the modifies/api This PR adds API routes or modifies them label Sep 23, 2023

Nabapadma-sarker added 2 commits September 24, 2023 09:28

url means APIURL

02af30d

repoAPIURL reused.

e5e41bf

CaiCandong approved these changes Sep 24, 2023

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 24, 2023

repo/repo.go file no need to change.

60c9f6a

lunny approved these changes Sep 24, 2023

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 24, 2023

yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 24, 2023

GiteaBot added 2 commits September 24, 2023 22:09

Merge branch 'main' into jenkins_push_event

0e97645

Merge branch 'main' into jenkins_push_event

ec1d700

techknowlogick enabled auto-merge (squash) September 24, 2023 18:12

techknowlogick merged commit 8e23524 into go-gitea:main Sep 24, 2023
25 checks passed

GiteaBot added this to the 1.22.0 milestone Sep 24, 2023

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 24, 2023

lunny added the backport/v1.20 This PR should be backported to Gitea 1.20 label Sep 25, 2023

lunny added the backport/v1.21 This PR should be backported to Gitea 1.21 label Sep 25, 2023

Nabapadma-sarker deleted the jenkins_push_event branch September 25, 2023 01:21

GiteaBot mentioned this pull request Sep 25, 2023

Fix PushEvent NullPointerException jenkinsci/github-plugin (#27203) #27249

Merged

GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Sep 25, 2023

Fix PushEvent NullPointerException jenkinsci/github-plugin (go-gitea#…

6ff3abd

…27203) Fixes go-gitea#27202

GiteaBot mentioned this pull request Sep 25, 2023

Fix PushEvent NullPointerException jenkinsci/github-plugin (#27203) #27251

Merged

GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Sep 25, 2023

Fix PushEvent NullPointerException jenkinsci/github-plugin (go-gitea#…

c459c42

…27203) Fixes go-gitea#27202

silverwind pushed a commit that referenced this pull request Sep 25, 2023

Fix PushEvent NullPointerException jenkinsci/github-plugin (#27203) (#…

4b37eb2

…27249) Backport #27203 by @Nabapadma-sarker Fixes #27202 Co-authored-by: Nabapadma-sarker <[email protected]>

GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Sep 25, 2023

silverwind pushed a commit that referenced this pull request Sep 25, 2023

Fix PushEvent NullPointerException jenkinsci/github-plugin (#27203) (#…

89b6f20

…27251) Backport #27203 by @Nabapadma-sarker Fixes #27202 Co-authored-by: Nabapadma-sarker <[email protected]>

go-gitea locked as resolved and limited conversation to collaborators Dec 23, 2023

lunny added the backport/done All backports for this PR have been created label Feb 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix PushEvent NullPointerException jenkinsci/github-plugin #27203

Fix PushEvent NullPointerException jenkinsci/github-plugin #27203

Nabapadma-sarker commented Sep 23, 2023

CaiCandong Sep 23, 2023

Nabapadma-sarker Sep 23, 2023

yardenshoham Sep 23, 2023

Nabapadma-sarker Sep 23, 2023

CaiCandong commented Sep 23, 2023

lunny commented Sep 24, 2023 •

edited

Loading

Nabapadma-sarker commented Sep 24, 2023

lunny commented Sep 24, 2023

Nabapadma-sarker commented Sep 24, 2023

lunny commented Sep 24, 2023

GiteaBot commented Sep 25, 2023

Fix PushEvent NullPointerException jenkinsci/github-plugin #27203

Fix PushEvent NullPointerException jenkinsci/github-plugin #27203

Conversation

Nabapadma-sarker commented Sep 23, 2023

CaiCandong Sep 23, 2023

Choose a reason for hiding this comment

Nabapadma-sarker Sep 23, 2023

Choose a reason for hiding this comment

yardenshoham Sep 23, 2023

Choose a reason for hiding this comment

Nabapadma-sarker Sep 23, 2023

Choose a reason for hiding this comment

CaiCandong commented Sep 23, 2023

lunny commented Sep 24, 2023 • edited Loading

Nabapadma-sarker commented Sep 24, 2023

lunny commented Sep 24, 2023

Nabapadma-sarker commented Sep 24, 2023

lunny commented Sep 24, 2023

GiteaBot commented Sep 25, 2023

lunny commented Sep 24, 2023 •

edited

Loading