Introduce fixes and more rigorous tests for 'Show on a map' feature #26803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
jolheiser
approved these changes
Sep 13, 2023
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Sep 13, 2023
pull-request-size
bot
added
size/S
This fixes an issue where the location map icon is not shown when viewing a user's Projects or Packages. Co-authored-by: Gusted <[email protected]>
n0toose
force-pushed
the
location-map-url-tweaks
branch
from
fffab22
to
19bc306
Compare
|
I force-pushed two commits: The one is basically original (with the small change recommended by @wxiaoguang) and an adjusted date. The other one is the test improvement that I sent back in August. |
delvh
approved these changes
Sep 25, 2023
GiteaBot
added
lgtm/done
wxiaoguang
reviewed
Sep 25, 2023
n0toose
force-pushed
the
location-map-url-tweaks
branch
from
19bc306
to
c72f726
Compare
pull-request-size
bot
added
size/XS
wxiaoguang
approved these changes
Sep 29, 2023
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
wxiaoguang
added
backport/v1.21
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Sep 30, 2023
…o-gitea#26803) This change introduces a fix for the PR go-gitea#26214 to set the UserLocationMapURL correctly.
|
Title is slightly misleading by now 😁. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces some fixes for my original PR (#26214) and introduces some additional tests so that such a regression does not happen again in the future.