Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fomantic text module #26777

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Remove fomantic text module #26777

merged 6 commits into from
Aug 30, 2023

Conversation

delvh
Copy link
Member

@delvh delvh commented Aug 28, 2023

Corollary to #26775:
All selectors I found that are actually used and not necessarily present in the current code have been copied to web_src/css/base.css.
Everything else should be a clean removal.

@delvh delvh added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 28, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 28, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 28, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 28, 2023
@silverwind
Copy link
Member

silverwind commented Aug 28, 2023 •
edited
Loading

We can potentially drop the !important from the .text.red classes etc, but it might have a side-effect or two.

@delvh
Copy link
Member Author

delvh commented Aug 28, 2023

Let's leave that for follow-up PRs…

@silverwind
Copy link
Member

silverwind commented Aug 28, 2023 •
edited
Loading

It'll likely be no issue, 2 classes is heavier than many things. But yes, we can do this another time, let's not forget it.

Edit: On second thought, let's keep important for now. I forsee some issues with the deeply nested repo selectors for example.

wxiaoguang
wxiaoguang reviewed Aug 28, 2023
View reviewed changes
web_src/css/base.css Outdated Show resolved Hide resolved
@delvh
Copy link
Member Author

delvh commented Aug 30, 2023

@wxiaoguang please re-review.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 30, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 30, 2023
@silverwind silverwind enabled auto-merge (squash) August 30, 2023 10:30
@silverwind silverwind merged commit 2590707 into go-gitea:main Aug 30, 2023
23 checks passed
@GiteaBot GiteaBot added this to the 1.21.0 milestone Aug 30, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 30, 2023
@delvh delvh deleted the remove-fomantic-text-module branch October 19, 2023 20:37
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@delvh @silverwind @wxiaoguang @GiteaBot