Fix display problems of members and teams unit #26363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
delvh
reviewed
Aug 7, 2023
routers/web/org/home.go
Outdated
Comment on lines
126
to
128
| if ctx.Doer != nil { | ||
| isMember, err := org.IsOrgMember(ctx.Doer.ID) | ||
| if err != nil { | ||
| ctx.Error(http.StatusInternalServerError, "IsOrgMember") | ||
| return | ||
| } | ||
| opts.PublicOnly = !isMember && !ctx.Doer.IsAdmin | ||
| opts.PublicOnly = !ctx.Org.IsMember && !ctx.Doer.IsAdmin | ||
| } |
There was a problem hiding this comment.
Why do we need this code block again, if we already checked it in HandleOrgAssignment?
Co-authored-by: delvh <[email protected]>
Co-authored-by: delvh <[email protected]>
silverwind
approved these changes
Aug 11, 2023
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Aug 11, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 17, 2023
* upstream/main: Sync repo's IsEmpty status correctly (go-gitea#26517) [skip ci] Updated translations via Crowdin Remove fomantic transition module (go-gitea#26469) Explain SearchOptions and fix ToSearchOptions (go-gitea#26542) Update go dependencies (go-gitea#26534) Differentiate better between user settings and admin settings (go-gitea#26538) Add missing triggers to update issue indexer (go-gitea#26539) Improve deadline icon location in milestone list page (go-gitea#26532) Use unique class for breadcrumb divider (go-gitea#26524) Fix typo of RunerOwnerID (go-gitea#26508) Improve clickable area in repo action view page (go-gitea#26115) Fix dark theme highlight for "NameNamespace" (go-gitea#26519) Remove duplicate CSS import for chroma/base.css (go-gitea#26523) Fix project filter bugs (go-gitea#26490) Fix display problems of members and teams unit (go-gitea#26363) Use `hidden` over `clip` for text truncation (go-gitea#26520) Add API route to list org secrets (go-gitea#26485) Set "type=button" for editor's toolbar buttons (go-gitea#26510) Apply to become a maintainer (go-gitea#26514) Detect ogg mime-type as audio or video (go-gitea#26494)
lunny
pushed a commit
that referenced
this pull request
Oct 30, 2023
…s in public org (#27795) Follow #26363. I missed that org templates also using `templates/user/overview/header.tmpl`. You can confirm this problem in https://gitea.com/gitea/-/projects with anonymous access. Before: (no login)  After: 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
In this org, we only have hidden members:
We will hidden the member board when doer is not the member of this org
Before:
If you click the number in the members board, you will access the members page, which is not expected.