-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for forking single branch #25821
Conversation
Extra idea: maybe we should support the same option for migrations? It's maybe even more useful in such case when people migrate (essentially fork a repo to their instance) for development purpose |
I understand the point of fork arbitrary branch, but list all branches at one time may cause performance problem. |
Fixes go-gitea#25117 Add UI for choosing branch to fork Change default branch on single-branch forks
502e790
to
0d4460d
Compare
Other places where branch list is used do render it in once. Listing branches and putting them into a template shouldn't hog the performance a lot |
@sh7dm Could you please resolve conflicts? I totally missed this PR, but it looks uncomplicated to review. Unfortunately we're already in feature freeze for 1.21 though... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like for you to use the new translation structure (see my suggestions), but in general, this PR seems to look good
Co-authored-by: Denys Konovalov <[email protected]>
Could you paste a screenshot? |
Co-authored-by: Lunny Xiao <[email protected]>
Alternative design idea: |
I think it's good idea but could be another PR. At least, this PR allow we fork with a single branch. |
Fixes #25117
Add UI for choosing branch to fork
Change default branch on single-branch forks