Fix repo search broken because of profile page added

[lunny]

Fix #25433
Caused by #23260

[silverwind]

Is a regression test possible for this? Serious regressions like this shouldn't be missed by the integration tests.

[wxiaoguang]

Is a regression test possible for this? Serious regressions like this shouldn't be missed by the integration tests.

ps: that's why I don't like PRs like "Fix ::User Profile Page - Project/Packages Tabs Have Inconsistent Layout #25108", these if blocks are too fragile.

[puni9869]

Is a regression test possible for this? Serious regressions like this shouldn't be missed by the integration tests.

ps: that's why I don't like PRs like "Fix ::User Profile Page - Project/Packages Tabs Have Inconsistent Layout #25108", these if blocks are too fragile.

Would you please suggest an approach to tackle the problem using a small code example?

[wxiaoguang]

Background: the thing I like doesn't mean it's liked by others, and the thing I don't like doesn't mean others don't like 😄 So, I share some my personal opinions, just for reference:

• For the "template" part, I think the shared parts could be made as page-independent as possible. It means that, the shared parts (components) layouts themselves, eg: use "width 100%" provided by its container.
• Let the caller's page decided the container layout, instead of {{if ThisPage}} <div "page-content foo"></div> {{else}} <div "page-content bar"></div> in the shared templates.
• For the backend part, the pages could be covered by integration tests.