Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "utf8mb4" for MySQL by default #25432

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Use "utf8mb4" for MySQL by default #25432

merged 1 commit into from
Jun 22, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jun 22, 2023 •
edited
Loading

TBH, I don't see much difference from Remove "CHARSET" config option for MySQL, always use "utf8mb4" #25413

Close #25378

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 22, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone Jun 22, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 22, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 22, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 22, 2023
@6543 6543 merged commit cb3173a into go-gitea:release/v1.20 Jun 22, 2023
@wxiaoguang wxiaoguang deleted the fix-mysql-charset branch June 22, 2023 05:56
@wxiaoguang wxiaoguang mentioned this pull request Jun 22, 2023
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

@lunny lunny Awaiting requested review from lunny

@delvh delvh Awaiting requested review from delvh

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @techknowlogick @6543 @GiteaBot