Fix setup-go actions #25167
Merged
Fix setup-go actions #25167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
silverwind
added
topic/build
|
Temporary change to backend files added to confirm that the actions now pass. Will revert before merge. |
lunny
approved these changes
Jun 9, 2023
GiteaBot
added
lgtm/need 1
wolfogre
reviewed
Jun 9, 2023
wolfogre
approved these changes
Jun 9, 2023
GiteaBot
added
lgtm/done
|
It still resolved to 1.20.4. I can only assume this is a bug in the action. |
|
Opened actions/setup-go#384 |
|
Maybe the problems are in https://github.com/actions/go-versions/releases |
This reverts commit a713f54.
silverwind
added
lgtm/blocked
|
Let's merge it. Builds should automatically start to pass once actions/setup-go#384 is resolved. |
GiteaBot
removed
the
reviewed/wait-merge
|
Actual fix is actions/go-versions#75 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 12, 2023
* upstream/main: [skip ci] Updated licenses and gitignores Add `WithPullRequest` for `actionsNotifier` (go-gitea#25144) [skip ci] Updated translations via Crowdin [skip ci] Updated translations via Crowdin Update github.com/google/go-github to v53 (go-gitea#25157) Fix bug for code search if code is disabled (go-gitea#25173) Minor arc-green color tweaks (go-gitea#25175) Fix duplicate Reviewed-by trailers (go-gitea#24796) Fix go-gitea#25133 (go-gitea#25162) Fix mobile navbar and misc cleanups (go-gitea#25134) Button and color enhancements (go-gitea#24989) Fix setup-go actions (go-gitea#25167) # Conflicts: # templates/base/head_navbar.tmpl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setup-goactions did not all havecheck-latestwhich means they use some cached version of go that currently still resolves to go1.20.4, as seen in a number of recent runs that currently fail at govulncheck because of it:Add the check-latest option which should guarantee that this cache is skipped.