Fix strange UI behavior of cancelling dismiss review modal (#25133) #25147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…25133) Fixes go-gitea#25130 The old code uses `$(this).next()` to get `dismiss-review-modal`. At first, it will get `$(#dismiss-review-modal)`, but the next time it will get `$(#dismiss-review-modal).next();` and then `$(#dismiss-review-modal).next().next();`. Because div `dismiss-review-modal` will be removed when `dismiss-review-btn` clicked. Maybe the right usage is adding `show-modal` class and `data-modal` attribute.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
wolfogre
approved these changes
Jun 8, 2023
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Jun 8, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
removed
the
reviewed/wait-merge
wxiaoguang
added
the
status/blocked
techknowlogick
requested changes
Jun 8, 2023
GiteaBot
added
lgtm/blocked
|
Blocked because of #25133 (comment). Once the fix is available, we can still merge this and then backport the fix. |
|
Merge this before the backport of #25162 |
|
#25172 contains this backport. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #25133 by @yp05327
Fixes #25130
The old code uses
$(this).next()to getdismiss-review-modal.At first, it will get
$(#dismiss-review-modal), but the next time it will get$(#dismiss-review-modal).next();and then
$(#dismiss-review-modal).next().next();.Because div
dismiss-review-modalwill be removed whendismiss-review-btnclicked.Maybe the right usage is adding
show-modalclass anddata-modalattribute.