Improve notification icon and navbar #25111
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -194,8 +194,8 @@ | |
| --color-input-toggle-background: #dedede; | ||
| --color-input-border: #dedede; | ||
| --color-input-border-hover: #cecece; | ||
| --color-header-wrapper: #f8f8f8; | ||
| --color-header-wrapper-transparent: #f8f8f800; | ||
| --color-light: #00000006; | ||
| --color-light-mimic-enabled: rgba(0, 0, 0, calc(6 / 255 * 222 / 255 / var(--opacity-disabled))); | ||
| --color-light-border: #0000001d; | ||
|
|
@@ -222,7 +222,8 @@ | |
| --color-reaction-active-bg: var(--color-primary-light-6); | ||
| --color-tooltip-text: #ffffff; | ||
| --color-tooltip-bg: #000000f0; | ||
| --color-nav-bg: #ffffff; | ||
| --color-nav-hover-bg: #ebebeb; | ||
| --color-label-text: #232323; | ||
| --color-label-bg: #cacaca5b; | ||
| --color-label-hover-bg: #cacacaa0; | ||
|
|
@@ -944,44 +945,44 @@ img.ui.avatar, | |
| } | ||
| } | ||
|
|
||
| #navbar { | ||
| display: flex; | ||
| align-items: center; | ||
| background: var(--color-nav-bg); | ||
| border-bottom: 1px solid var(--color-secondary); | ||
| width: 100vw; | ||
| min-height: 52px; | ||
| margin: 0 !important; | ||
| } | ||
|
|
||
| #navbar .column .menu { | ||
|
There was a problem hiding this comment. There seems no |
||
| margin-top: 0; | ||
| } | ||
|
|
||
| #navbar .fitted .svg { | ||
| margin-right: 0; | ||
| vertical-align: middle; | ||
| } | ||
|
|
||
| #navbar .searchbox { | ||
|
There was a problem hiding this comment. There seems no There was a problem hiding this comment. Yes, this searchbox is commented out in templates as a TODO, we can clean this up. |
||
| background-color: var(--color-input-background) !important; | ||
| } | ||
|
|
||
| #navbar .text .svg { | ||
| width: 16px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| #navbar a.item:hover { | ||
| background: var(--color-nav-hover-bg); | ||
| } | ||
|
|
||
| #navbar .dropdown .avatar { | ||
| margin-right: 0 !important; | ||
| } | ||
|
|
||
| @media (max-width: 767px) { | ||
| #navbar:not(.shown) > *:not(:first-child) { | ||
| display: none; | ||
| } | ||
| } | ||
|
|
@@ -1574,7 +1575,7 @@ img.ui.avatar, | |
|
|
||
| .ui.menu.new-menu { | ||
| margin-bottom: 15px; | ||
| background: var(--color-header-wrapper); | ||
| border-bottom: 1px solid var(--color-secondary) !important; | ||
| overflow: auto; | ||
| } | ||
|
|
@@ -1589,7 +1590,7 @@ img.ui.avatar, | |
| .ui.menu.new-menu::after { | ||
| position: absolute; | ||
| display: block; | ||
| background: linear-gradient(to right, var(--color-header-wrapper-transparent), var(--color-header-wrapper) 100%); | ||
| content: ''; | ||
| right: 0; | ||
| height: 39px; | ||
|
|
@@ -2124,24 +2125,31 @@ a.ui.basic.label:hover { | |
| width: 13px; | ||
| height: 13px; | ||
| background: var(--color-primary); | ||
| border: 2px solid var(--color-nav-bg); | ||
| border-radius: 100%; | ||
| } | ||
|
|
||
| .notification_count { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| position: absolute; | ||
| left: 6px; | ||
| top: -8px; | ||
| min-width: 17px; | ||
| min-height: 17px; | ||
| background: var(--color-primary); | ||
| border: 2px solid var(--color-nav-bg); | ||
| color: var(--color-nav-bg); | ||
| border-radius: 17px; | ||
| padding: 0 3.5px; | ||
| font-size: 12px; | ||
| line-height: 12px; | ||
| font-weight: var(--font-weight-bold); | ||
| } | ||
|
|
||
| #navbar a.item:hover .notification_count { | ||
| border-color: var(--color-nav-hover-bg); | ||
| } | ||
|
|
||
| .rss-icon { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| .explore .navbar { | ||
| margin-bottom: 15px !important; | ||
| background-color: var(--color-header-wrapper) !important; | ||
| border-width: 1px !important; | ||
| } | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -132,7 +132,7 @@ | |
| } | ||
|
|
||
| .repository .header-wrapper { | ||
| background-color: var(--color-header-wrapper); | ||
| } | ||
|
|
||
| .repository .header-wrapper .ui.tabs.divider { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -180,8 +180,8 @@ | |
| --color-input-toggle-background: #454a57; | ||
| --color-input-border: #454a57; | ||
| --color-input-border-hover: #505667; | ||
|
There was a problem hiding this comment. Just a question, since the names have been changed, will third party themes be broken? There was a problem hiding this comment. Yes, they need to do the rename as well. I try to avoid such breaks, but in this case it was necessary because otherwise the naming would have been very confusing. |
||
| --color-header-wrapper: #2a2e3a; | ||
| --color-header-wrapper-transparent: #2a2e3a00; | ||
| --color-light: #00000028; | ||
| --color-light-mimic-enabled: rgba(0, 0, 0, calc(40 / 255 * 222 / 255 / var(--opacity-disabled))); | ||
| --color-light-border: #ffffff28; | ||
|
|
@@ -207,7 +207,8 @@ | |
| --color-reaction-active-bg: var(--color-primary-light-5); | ||
| --color-tooltip-text: #ffffff; | ||
| --color-tooltip-bg: #000000f0; | ||
| --color-nav-bg: #2e323e; | ||
| --color-nav-hover-bg: #434651; | ||
| --color-label-text: #dfe3ec; | ||
| --color-label-bg: #7c84974b; | ||
| --color-label-hover-bg: #7c8497a0; | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it shouldn't use
containerhere (although it's from old code)ui containermeans limited width (not full width).The
mainalso seems a no-op here.Update : maybe thesecondaryis also a no-op now, because the bg color is provided by#navbarnow.tested,
secondaryis necessary.The minimal styles are:
class="ui secondary stackable menu"