Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not output "Trace" level logs from process manager by default #24952

Merged
merged 2 commits into from
May 27, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented May 27, 2023

The old process manager's Trace function by default calls log.Printf to output "trace" level logs. That's not ideal because by default the trace level logs should not be outputted. In history it didn't cause problems because there was no other call to the process manager before the logger system's initialization.

But if there is any package using the process manager before the "Trace" function gets assigned to the logger system's trace function, the process manager will outputs unexpected verbose messages, this behavior is not expected in most cases.

Now, the logger system also uses process manager to manage its goroutine contexts, so it's the time to fix the old "trace" behavior: by default, do not output the trace level messages. Fix #24951

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 27, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 27, 2023
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 27, 2023
@wxiaoguang wxiaoguang added this to the 1.20.0 milestone May 27, 2023
@wxiaoguang wxiaoguang force-pushed the fix-process-trace-log branch 2 times, most recently from 71341fd to 9357b79 Compare May 27, 2023 03:48
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 27, 2023
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented May 27, 2023

3rd-party CI failure, git.sr.ht/~mariusor/go-xsd-duration cert expires.

#14 643.9 go: downloading git.sr.ht/~mariusor/go-xsd-duration v0.0.0-20220703122237-02e73435a078
#14 644.5 /go/pkg/mod/github.com/go-ap/[email protected]/encoding_json.go:8:2: unrecognized import path "git.sr.ht/~mariusor/go-xsd-duration": https fetch: Get "https://git.sr.ht/~mariusor/go-xsd-duration?go-get=1": tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2023-05-27T05:12:24Z is after 2023-05-27T00:00:06Z
#14 644.5 make: *** [Makefile:820: gitea] Error 1
$ go mod why git.sr.ht/~mariusor/go-xsd-duration                                                                                                                                                                                                                       
# git.sr.ht/~mariusor/go-xsd-duration
code.gitea.io/gitea/routers/api/v1/activitypub
github.com/go-ap/activitypub
git.sr.ht/~mariusor/go-xsd-duration

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 27, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 27, 2023
@silverwind silverwind enabled auto-merge (squash) May 27, 2023 10:25
@silverwind silverwind merged commit 7314726 into go-gitea:main May 27, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 27, 2023
@wxiaoguang wxiaoguang deleted the fix-process-trace-log branch May 27, 2023 11:00
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 29, 2023
* upstream/main:
  Test query must have "order by" explicitly to avoid unstable results (go-gitea#24963)
  Help to recover from corrupted levelqueue (go-gitea#24912)
  [skip ci] Updated translations via Crowdin
  Remove meta tags `theme-color` and `default-theme` (go-gitea#24960)
  Add dark mode to API Docs (go-gitea#24971)
  Update JS dependencies (go-gitea#24969)
  Replace Fomantic reset module with our own (go-gitea#24948)
  simple docs fixes: 'pull request' page (en-us & zh-tw) link path to 'issue-pull-request-templates' (go-gitea#24961)
  Remove reference to caddy v1 in docs (go-gitea#24962)
  Improve and fix bugs surrounding reactions (go-gitea#24760)
  Use `[git.config]` for reflog cleaning up (go-gitea#24958)
  Improve logger Pause handling (go-gitea#24946)
  Do not output "Trace" level logs from process manager by default (go-gitea#24952)
  Make the 500 page load themes (go-gitea#24953)
  [skip ci] Updated translations via Crowdin
  docs: remove an extraneous whitespace (go-gitea#24949)
  Show `bot` label next to username when rendering autor link if the user is a bot (go-gitea#24943)
  Improve some Forms (go-gitea#24878)
  Improve queue and logger context (go-gitea#24924)
  Fix ref type error (go-gitea#24941)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git client cluttered since update of container
4 participants