-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not output "Trace" level logs from process manager by default #24952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
May 27, 2023
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
May 27, 2023
wxiaoguang
added
the
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
label
May 27, 2023
wxiaoguang
force-pushed
the
fix-process-trace-log
branch
2 times, most recently
from
May 27, 2023 03:48
71341fd
to
9357b79
Compare
wxiaoguang
force-pushed
the
fix-process-trace-log
branch
from
May 27, 2023 04:59
9357b79
to
35240da
Compare
lunny
approved these changes
May 27, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
May 27, 2023
3rd-party CI failure,
|
silverwind
approved these changes
May 27, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
May 27, 2023
silverwind
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
May 27, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
May 27, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 29, 2023
* upstream/main: Test query must have "order by" explicitly to avoid unstable results (go-gitea#24963) Help to recover from corrupted levelqueue (go-gitea#24912) [skip ci] Updated translations via Crowdin Remove meta tags `theme-color` and `default-theme` (go-gitea#24960) Add dark mode to API Docs (go-gitea#24971) Update JS dependencies (go-gitea#24969) Replace Fomantic reset module with our own (go-gitea#24948) simple docs fixes: 'pull request' page (en-us & zh-tw) link path to 'issue-pull-request-templates' (go-gitea#24961) Remove reference to caddy v1 in docs (go-gitea#24962) Improve and fix bugs surrounding reactions (go-gitea#24760) Use `[git.config]` for reflog cleaning up (go-gitea#24958) Improve logger Pause handling (go-gitea#24946) Do not output "Trace" level logs from process manager by default (go-gitea#24952) Make the 500 page load themes (go-gitea#24953) [skip ci] Updated translations via Crowdin docs: remove an extraneous whitespace (go-gitea#24949) Show `bot` label next to username when rendering autor link if the user is a bot (go-gitea#24943) Improve some Forms (go-gitea#24878) Improve queue and logger context (go-gitea#24924) Fix ref type error (go-gitea#24941)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old process manager's
Trace
function by default callslog.Printf
to output "trace" level logs. That's not ideal because by default the trace level logs should not be outputted. In history it didn't cause problems because there was no other call to the process manager before the logger system's initialization.But if there is any package using the process manager before the "Trace" function gets assigned to the logger system's trace function, the process manager will outputs unexpected verbose messages, this behavior is not expected in most cases.
Now, the logger system also uses process manager to manage its goroutine contexts, so it's the time to fix the old "trace" behavior: by default, do not output the trace level messages. Fix #24951