Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DeleteIssue use correct context #24885

Merged
merged 2 commits into from
May 23, 2023
Merged

Make DeleteIssue use correct context #24885

merged 2 commits into from
May 23, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented May 23, 2023 •
edited
Loading

Fix #24884 , the ctx.Repo.GitRepo might be nil.

@GiteaBot GiteaBot added this to the 1.19.4 milestone May 23, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 23, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 23, 2023
@wxiaoguang wxiaoguang mentioned this pull request May 23, 2023
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 23, 2023
@lunny lunny added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label May 23, 2023
@GiteaBot GiteaBot removed the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label May 23, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 23, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 23, 2023
@techknowlogick techknowlogick merged commit d19d5bc into go-gitea:release/v1.19 May 23, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 23, 2023
@wxiaoguang wxiaoguang deleted the fix-delete-issue-nil branch May 24, 2023 02:27
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jun 3, 2023
@wxiaoguang @earl-warren
Make DeleteIssue use correct context (go-gitea#24885)
936eb64 
Fix go-gitea#24884 , the `ctx.Repo.GitRepo` might be nil.

(cherry picked from commit d19d5bc)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.19.4
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @lunny @silverwind @techknowlogick @GiteaBot