Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support changing labels of Actions runner without re-registration #24806

Merged
merged 27 commits into from
Jun 13, 2023
Merged

Support changing labels of Actions runner without re-registration #24806

merged 27 commits into from
Jun 13, 2023

Conversation

sillyguodong
Copy link
Contributor

@sillyguodong sillyguodong commented May 19, 2023 •
edited
Loading

close #24540

related:

changes:

  • Add column of labels to table action_runner, and combine the value of agent_labels and custom_labels column to labels column.
  • Store labels when registering act_runner.
  • Update labels when act_runner starting and calling Declare.
  • Users cannot modify the custom labels in edit page any more.

other changes:

  • Store version when registering act_runner.
  • If runner is latest version, parse version from Declare. But older version runner still parse version from request header.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 19, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 19, 2023
@sillyguodong sillyguodong added the topic/gitea-actions related to the actions of Gitea label May 19, 2023
@wolfogre wolfogre self-requested a review June 5, 2023 10:42
@sillyguodong sillyguodong marked this pull request as ready for review June 6, 2023 03:46
@sillyguodong sillyguodong changed the title [WIP] Support changing labels of Actions runner without re-registration Support changing labels of Actions runner without re-registration Jun 6, 2023
wolfogre
wolfogre reviewed Jun 9, 2023
View reviewed changes
models/actions/runner.go Outdated Show resolved Hide resolved
models/migrations/v1_20/v260.go Outdated Show resolved Hide resolved
routers/web/shared/actions/runners.go Outdated Show resolved Hide resolved
templates/shared/actions/runner_edit.tmpl Show resolved Hide resolved
models/migrations/migrations.go Outdated Show resolved Hide resolved
wolfogre
wolfogre reviewed Jun 9, 2023
View reviewed changes
models/migrations/migrations.go Show resolved Hide resolved
routers/api/actions/runner/runner.go Outdated Show resolved Hide resolved
wolfogre
wolfogre approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@wolfogre wolfogre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 9, 2023
@sillyguodong sillyguodong mentioned this pull request Jun 13, 2023
Closed
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 13, 2023
@lunny lunny added this to the 1.21.0 milestone Jun 13, 2023
wolfogre
wolfogre reviewed Jun 13, 2023
View reviewed changes
models/migrations/migrations.go Outdated Show resolved Hide resolved
models/migrations/v1_21/v260.go Outdated Show resolved Hide resolved
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 13, 2023
@lunny lunny merged commit 8228751 into go-gitea:main Jun 13, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 13, 2023
@sillyguodong sillyguodong mentioned this pull request Jun 14, 2023
Merged
lunny pushed a commit that referenced this pull request Jun 14, 2023
@sillyguodong
Fix description of drop custom_labels migration (#25243)
020ab3d 
Follow: #24806
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 15, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
de2c98c 
* upstream/main: (31 commits)
  Show OAuth2 errors to end users (go-gitea#25261)
  [skip ci] Updated translations via Crowdin
  Fix index generation parallelly failure (go-gitea#25235)
  Fix variable in template (go-gitea#25267)
  Add template linting via djlint (go-gitea#25212)
  Fix edit OAuth application width (go-gitea#25262)
  Use flex to align SVG and text (go-gitea#25163)
  GitHub Actions enhancements for frontend (go-gitea#25150)
  Add missing `v` in migrations.go (go-gitea#25252)
  Change form actions to fetch for submit review box (go-gitea#25219)
  Fix panic when migrating a repo from GitHub with issues (go-gitea#25246)
  Fix description of drop custom_labels migration (go-gitea#25243)
  Fix all possible setting error related storages and added some tests (go-gitea#23911)
  [skip ci] Updated translations via Crowdin
  Revert overflow: overlay (revert go-gitea#21850) (go-gitea#25231)
  Support changing labels of Actions runner without re-registration (go-gitea#24806)
  Improve AJAX link and modal confirm dialog (go-gitea#25210)
  Use inline SVG for built-in OAuth providers (go-gitea#25171)
  Disable `Create column` button while the column name is empty  (go-gitea#25192)
  Fix profile render when the README.md size is larger than 1024 bytes (go-gitea#25131)
  ...
@ExplodingDragon
Copy link
Contributor

Will this patch be backported to 1.20?

@lunny
Copy link
Member

lunny commented Jun 15, 2023

Will this patch be backported to 1.20?

It will not

This was referenced Jun 18, 2023
Merged
Closed
NexZhu pushed a commit to daotl/gitea_act_runner that referenced this pull request Jun 20, 2023
@sillyguodong @wolfogre
Support changing labels (#201)
67b1363 
Implement proposal: go-gitea/gitea#24540

Related:
- Protocol: https://gitea.com/gitea/actions-proto-def/pulls/9
- Gitea side: go-gitea/gitea#24806

Co-authored-by: Jason Song <[email protected]>
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/201
Reviewed-by: Jason Song <[email protected]>
Co-authored-by: sillyguodong <[email protected]>
Co-committed-by: sillyguodong <[email protected]>
@sillyguodong sillyguodong mentioned this pull request Aug 4, 2023
Merged
lunny pushed a commit that referenced this pull request Aug 4, 2023
@sillyguodong
Update documentation for 1.21 actions (#26317)
0da8ebc 
As title.
Close #26309
Related to #24724, #24806
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 11, 2023
@denyskon denyskon added the type/enhancement An improvement of existing functionality label Nov 13, 2023
@sillyguodong sillyguodong deleted the feature/declare_labels branch February 29, 2024 03:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wolfogre wolfogre wolfogre approved these changes

@wxiaoguang wxiaoguang wxiaoguang left review comments

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/gitea-actions related to the actions of Gitea type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

[Proposal] Support changing labels of Actions runner without re-registration
7 participants
@sillyguodong @ExplodingDragon @lunny @wxiaoguang @wolfogre @GiteaBot @denyskon