Fix the permission of team's Actions
unit issue (#24536)
#24545
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #24536 by @sillyguodong
close #24449
The unit of
Actions
should be contorlled not only byrepository.DISABLED_REPO_UNITS
but also byactions.ENABLED
in the
app.ini
.Previously, the permission of the team's
Actions
unit was not controlled byactions.Enabled
. So, even if the user setsactions.Enabled
to false, he can still select the permission of theActions
unit for the team.This PR makes the permissions of the team's
Actions
unit also controlled byactions.Enabled
. Just appendTypeActions
intoDisabledRepoUnits
slice when initializing ifactions.Enabled
is false.Changes:
If
Actions
is set disbaled inapp.ini
, like below:Actions
is disbaled.actions
is not displayed in the sidebar on the team details page