Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 20 on CI, enable actions cancellation #24524

Merged
merged 10 commits into from
May 4, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .drone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ steps:
- git fetch --tags --force

- name: deps-frontend
image: node:18
image: node:20
pull: always
commands:
- make deps-frontend
Expand All @@ -51,7 +51,7 @@ steps:
image: techknowlogick/xgo:go-1.20.x
pull: always
commands:
# Upgrade to node 18 once https://github.com/techknowlogick/xgo/issues/163 is resolved
# Upgrade to node 20 once https://github.com/techknowlogick/xgo/issues/163 is resolved
- curl -sL https://deb.nodesource.com/setup_16.x | bash - && apt-get -qqy install nodejs
- export PATH=$PATH:$GOPATH/bin
- make release
Expand Down Expand Up @@ -161,7 +161,7 @@ steps:
- git fetch --tags --force

- name: deps-frontend
image: node:18
image: node:20
pull: always
commands:
- make deps-frontend
Expand All @@ -179,7 +179,7 @@ steps:
image: techknowlogick/xgo:go-1.20.x
pull: always
commands:
# Upgrade to node 18 once https://github.com/techknowlogick/xgo/issues/163 is resolved
# Upgrade to node 20 once https://github.com/techknowlogick/xgo/issues/163 is resolved
- curl -sL https://deb.nodesource.com/setup_16.x | bash - && apt-get -qqy install nodejs
- export PATH=$PATH:$GOPATH/bin
- make release
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pull-compliance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
- name: setup node
uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
- name: deps-frontend
run: make deps-frontend
- name: lint frontend
Expand All @@ -100,7 +100,7 @@ jobs:
- name: setup node
uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
- name: deps-backend
run: make deps-backend deps-tools
- name: deps-frontend
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pull-compliance_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ jobs:
- name: checkout
uses: actions/checkout@v3
- name: setup node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
- name: install dependencies
run: make deps-frontend
- name: lint markdown
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: setup node
uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
- name: build
run: make deps-frontend frontend deps-backend
- name: Install playwright browsers
Expand Down