Fix commits pushed with deploy keys not shown in dashboard

[Zettat123]

Fix #21324

In the current logic, if the Actor user is not an admin user, all activities from private organizations won't be shown even if the Actor user is a member of the organization.

As mentioned in the issue, when using deploy key to make a commit and push, the activity's act_user_id will be the id of the organization so the activity won't be shown to non-admin users because the visibility of the organization is private.

gitea/models/activities/action.go

Lines 490 to 503 in 55a5717

	if opts.Actor == nil {
	cond = cond.And(builder.In("act_user_id",
	builder.Select("`user`.id").Where(
	builder.Eq{"keep_activity_private": false, "visibility": structs.VisibleTypePublic},
	).From("`user`"),
	))
	} else if !opts.Actor.IsAdmin {
	cond = cond.And(builder.In("act_user_id",
	builder.Select("`user`.id").Where(
	builder.Eq{"keep_activity_private": false}.
	And(builder.In("visibility", structs.VisibleTypePublic, structs.VisibleTypeLimited))).
	Or(builder.Eq{"id": opts.Actor.ID}).From("`user`"),
	))
	}

This PR improves this logic so the activities of private organizations can be shown.

[wxiaoguang]

Haven't tested, I have a question:

Is the new SQL friendly to action table? The action table could be pretty large.

[Zettat123]

Is the new SQL friendly to action table? The action table could be pretty large.

Yes, the action table may be large. But the query logic doesn't change, we always need a cond.And(builder.In("act_user_id", uidCond)) to select the action.act_user_id. I only improved the uidCond and fixed some missing user.id.