Fix auth check bug (#24382) #24387
Merged
Fix auth check bug (#24382) #24387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix https://github.com/go-gitea/gitea/pull/24362/files#r1179095324 `getAuthenticatedMeta` has checked them, these code are duplicated one. And the first invokation has a wrong permission check. `DownloadHandle` should require read permission but not write.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
6543
approved these changes
Apr 27, 2023
GiteaBot
added
lgtm/need 1
jolheiser
approved these changes
Apr 27, 2023
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
yardenshoham
approved these changes
Apr 27, 2023
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #24382 by @lunny
Fix https://github.com/go-gitea/gitea/pull/24362/files#r1179095324
getAuthenticatedMetahas checked them, these code are duplicated one. And the first invokation has a wrong permission check.DownloadHandleshould require read permission but not write.