Use on/trigger event

[yp05327]

No description provided.

[codecov-commenter]

Codecov Report

Merging #24098 (892beb8) into main (f521e88) will decrease coverage by 0.06%.
The diff coverage is 39.34%.

❗ Current head 892beb8 differs from pull request most recent head 55667d3. Consider uploading reports for the commit 55667d3 to get more accurate results

@@            Coverage Diff             @@
##             main   #24098      +/-   ##
==========================================
- Coverage   47.14%   47.09%   -0.06%     
==========================================
  Files        1149     1161      +12     
  Lines      151446   153912    +2466     
==========================================
+ Hits        71397    72479    +1082     
- Misses      71611    72910    +1299     
- Partials     8438     8523      +85     

Impacted Files	Coverage Δ
cmd/dump.go	0.64% <0.00%> (-0.03%)	⬇️
cmd/embedded.go	0.00% <0.00%> (ø)
cmd/mailer.go	0.00% <0.00%> (ø)
cmd/manager.go	0.00% <0.00%> (ø)
cmd/manager_logging.go	0.00% <0.00%> (ø)
cmd/migrate_storage.go	5.76% <0.00%> (-0.12%)	⬇️
cmd/restore_repo.go	0.00% <0.00%> (ø)
cmd/web.go	0.00% <0.00%> (ø)
models/actions/run.go	1.63% <0.00%> (-0.10%)	⬇️
models/actions/runner.go	1.44% <ø> (ø)
... and 57 more

... and 140 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[wxiaoguang]

I think it's correct 👍

[yardenshoham]

What's the benefit?

[lunny]

What's the benefit?

on could work on those dynamiclly added elements but click not.

[silverwind]

What's the benefit?

on could work on those dynamiclly added elements but click not.

No, that would only go for delegated listeners which these are not, so this is a pure refactor.

Still I think it's a good change and we should probably install this eslint rule to find and eliminate such cases. @yp05327 want to try adding it?

[silverwind]

Actually I think that eslint plugin can come later. Adding new plugin is a bit of a more involved task as each rule needs to be evalutated etc.

[yp05327]

@silverwind
Try adding it in #24198

[yp05327]

Change to draft as I think we need to fix all lint error in #24198

[silverwind]

Let's continue in #24198, it's more thorough and does the same.