Make bindata static build parse builtin templates correctly #24003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #24002
Two problems before:
log.Fatal
is missing after thesewrapFatal
calls, so the error is not shown to users.GetTemplateAssetNames
has different behaviors for local files and builtin assets, for builtin assets, it also returns directories, so we need to check the extension again.I have tested with
TAGS="bindata sqlite sqlite_unlock_notify" make build && ./gitea
, it works well now. Before, the server responds internal server error (because it doesn't complete the template parsing)