Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint-plugin-custom-elements #23991

Merged
merged 2 commits into from
Apr 8, 2023
Merged

Add eslint-plugin-custom-elements #23991

merged 2 commits into from
Apr 8, 2023

Conversation

silverwind
Copy link
Member

Add eslint-plugin-custom-elements and enable all rules that I've found sensible.

@silverwind silverwind added this to the 1.20.0 milestone Apr 7, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 7, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 8, 2023
@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Apr 8, 2023
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Apr 8, 2023
@silverwind silverwind enabled auto-merge (squash) April 8, 2023 08:37
@silverwind silverwind merged commit 3037922 into go-gitea:main Apr 8, 2023
@silverwind silverwind deleted the eslint-plugin-custom-elements branch April 8, 2023 09:24
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 9, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @lunny @yardenshoham @delvh @GiteaBot