-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcode path to docker images #23955
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
added
the
topic/build
PR changes how Gitea is built, i.e. regarding Docker or the Makefile
label
Apr 6, 2023
delvh
approved these changes
Apr 6, 2023
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Apr 6, 2023
jolheiser
approved these changes
Apr 6, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Apr 6, 2023
Is the Also we may want to update image names in |
techknowlogick
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Apr 6, 2023
yardenshoham
approved these changes
Apr 6, 2023
techknowlogick
added
the
outdated/backport/v1.19
This PR should be backported to Gitea 1.19
label
Apr 7, 2023
🤖 🎺 |
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 7, 2023
Fix go-gitea#23954 This allows for building on platforms that don't have docker hub as the default container registry.
lunny
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Apr 7, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 7, 2023
* upstream/main: Clean template/helper.go (go-gitea#23922) Remove `Repository.getFilesChanged` to fix Actions `paths` and `paths-ignore` filter (go-gitea#23920) Hardcode path to docker images (go-gitea#23955) Title can be empty when creating tag only (go-gitea#23917) Actions: Use default branch as ref when a branch/tag delete occurs (go-gitea#23910) Refactor authors dropdown (send get request from frontend to avoid long wait time) (go-gitea#23890) [skip ci] Updated translations via Crowdin Merge `push to create`, `open PR from push`, and `push options` docs articles into one (go-gitea#23744) Delete deleted release attachments immediately from storage (go-gitea#23913) More specific and unique feed name for NuGet install command template. (go-gitea#23889) Treat PRs with agit flow as fork PRs when triggering actions. (go-gitea#23884) Use graceful editorconfig loader to reduce errors when loading malformed editorconfigs (go-gitea#21257) Remove -v from vulncheck (go-gitea#23953) Improve permission check of packages (go-gitea#23879) Adjust some documentations titles (go-gitea#23941)
6543
pushed a commit
that referenced
this pull request
Apr 7, 2023
Backport #23955 by @techknowlogick Fix #23954 This allows for building on platforms that don't have docker hub as the default container registry. Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
outdated/backport/v1.19
This PR should be backported to Gitea 1.19
topic/build
PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #23954
This allows for building on platforms that don't have docker hub as the default container registry.