Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left-align review comments #23937

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Left-align review comments #23937

merged 1 commit into from
Apr 6, 2023

Conversation

silverwind
Copy link
Member

Small extract from #23553 for 1.19:

Before:
Screenshot 2023-04-05 at 21 47 55

After:
Screenshot 2023-04-05 at 21 47 38

@silverwind silverwind added the type/enhancement An improvement of existing functionality label Apr 5, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Apr 5, 2023
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Apr 5, 2023
@techknowlogick techknowlogick modified the milestones: 1.20.0, 1.19.1 Apr 5, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 6, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 6, 2023
@KN4CK3R KN4CK3R merged commit 8092251 into go-gitea:release/v1.19 Apr 6, 2023
@silverwind silverwind deleted the comment-left branch April 6, 2023 07:56
@silverwind silverwind restored the comment-left branch April 6, 2023 17:58
@silverwind silverwind deleted the comment-left branch April 6, 2023 18:28
@HesterG HesterG mentioned this pull request May 19, 2023
Merged
silverwind pushed a commit that referenced this pull request May 19, 2023
@HesterG @GiteaBot
Fix max width and margin of comment box on conversation page (#24809)
acde12a 
Fix regression from #23937

The changes should only be limited to `.conversation-holder
.comment-code-cloud`, otherwise it will affect the `.comment-code-cloud`
in conversation tab

Before:

<img width="962" alt="Screen Shot 2023-05-19 at 18 22 25"
src="https://github.com/go-gitea/gitea/assets/17645053/0db01d04-2581-48f9-b46c-497836b1f12b">

After:

<img width="997" alt="Screen Shot 2023-05-19 at 18 35 01"
src="https://github.com/go-gitea/gitea/assets/17645053/5d14b67b-88c1-46c6-b859-fd41752b3ebb">

---------

Co-authored-by: Giteabot <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.19.1
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @KN4CK3R @yardenshoham @techknowlogick @GiteaBot