Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to catch more broken translations #23867

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

wxiaoguang
Copy link
Contributor

Result: #23866

Gitea should drop the ` as string quoter, it is not recognized by Crowdin and it causes problem for translators.

@wxiaoguang wxiaoguang force-pushed the improve-backport-locales branch 6 times, most recently from bcdd547 to 897c216 Compare April 2, 2023 01:53
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2023

Codecov Report

Merging #23867 (1b50355) into main (f521e88) will decrease coverage by 0.15%.
The diff coverage is 28.82%.

❗ Current head 1b50355 differs from pull request most recent head 3c1a5ae. Consider uploading reports for the commit 3c1a5ae to get more accurate results

@@            Coverage Diff             @@
##             main   #23867      +/-   ##
==========================================
- Coverage   47.14%   46.99%   -0.15%     
==========================================
  Files        1149     1158       +9     
  Lines      151446   153187    +1741     
==========================================
+ Hits        71397    71993     +596     
- Misses      71611    72700    +1089     
- Partials     8438     8494      +56     
Impacted Files Coverage Δ
cmd/dump.go 0.66% <0.00%> (-0.01%) ⬇️
cmd/mailer.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/manager_logging.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 5.76% <0.00%> (-0.12%) ⬇️
cmd/restore_repo.go 0.00% <0.00%> (ø)
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.63% <0.00%> (-0.10%) ⬇️
models/actions/runner.go 1.44% <ø> (ø)
models/packages/package.go 45.45% <0.00%> (-1.13%) ⬇️
... and 66 more

... and 71 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 2, 2023
@lunny lunny added modifies/translation reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 2, 2023
@lunny lunny merged commit c2ff2a4 into go-gitea:main Apr 3, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 3, 2023
@wxiaoguang wxiaoguang deleted the improve-backport-locales branch April 3, 2023 03:13
@delvh delvh added this to the 1.20.0 milestone Apr 3, 2023
@delvh delvh added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 3, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 4, 2023
* upstream/main:
  Use User.ID instead of User.Name in ActivityPub API for Person IRI (go-gitea#23823)
  Remove fomantic ".link" selector and styles (go-gitea#23888)
  [skip ci] Updated translations via Crowdin
  Fix `cases.Title` crash for concurrency (go-gitea#23885)
  Disable editing tags (go-gitea#23883)
  Fix user profile description rendering (go-gitea#23882)
  Introduce GiteaLocaleNumber custom element to handle number localization on pages. (go-gitea#23861)
  Convert .Source.SkipVerify to $cfg.SkipVerify (go-gitea#23839)
  Fix review box viewport overflow issue (go-gitea#23800)
  Fix owner team access mode value in team_unit table (go-gitea#23675)
  Fix submit button won't refresh in New Repository Fork page (go-gitea#22994)
  Introduce GitHub markdown editor, keep EasyMDE as fallback (go-gitea#23876)
  Improve LoadUnitConfig to handle invalid or duplicate units (go-gitea#23736)
  Append `(comment)` when a link points at a comment rather than the whole issue (go-gitea#23734)
  Rename actions unit to `repo.actions` and add docs for it (go-gitea#23733)
  Try to catch more broken translations (go-gitea#23867)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants