Use minio/sha256-simd for accelerated SHA256 #23052
Conversation
minio/sha256-simd provides additional acceleration for SHA256 using AVX512, SHA Extensions for x86 and ARM64 for ARM. It provides a drop-in replacement for crypto/sha256 and if the extensions are not available it falls back to standard crypto/sha256. Signed-off-by: Andrew Thornton <[email protected]>
|
Clearly this is not a complete drop-in replacement... It appears to be missing the implementation for BinaryEncoder... OK... |
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <[email protected]>
|
I think once minio/sha256-simd#68 is merged there's potential for further improvement here. |
|
Given the CI failure in c304241 that means that the CI runners should have support for these extensions. That means that this is likely to cause a measurable improvement in speed of CI. |
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
delvh
added
the
reviewed/wait-merge
|
I wonder why they did not just upstream the improvements into I'm generally wary of such "speed improvements" as the code quality often does not match the standards of the stdlib as seen by various broken JSON implementations, for example. |
|
They're trying to upstream the changes but go is being a little slow to pull them. Agreed in general about speed improvements not necessarily being worth it, but this is being used by minio and is written by minio and has a good test suite. |
jolheiser
removed
the
reviewed/wait-merge
* giteaofficial/main: Improve reverse proxies documentation (go-gitea#23068) Improve accessibility for issue comments (go-gitea#22612) Wrap unless-check in docker manifests (go-gitea#23079) Add accessibility to the menu on the navbar (go-gitea#23059) Use minio/sha256-simd for accelerated SHA256 (go-gitea#23052) Fix some more hidden problems (go-gitea#23074) Add sillyguodong to maintainers (go-gitea#23067) Improving CONTRIBUTING.md for backport details (go-gitea#23057)
minio/sha256-simd provides additional acceleration for SHA256 using AVX512, SHA Extensions for x86 and ARM64 for ARM.
It provides a drop-in replacement for crypto/sha256 and if the extensions are not available it falls back to standard crypto/sha256.