Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian package registry #22854

Merged
merged 41 commits into from
Apr 28, 2023
Merged

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Feb 10, 2023

Co-authored-by: @awkwardbunny

This PR adds a Debian package registry. You can follow this tutorial to build a *.deb package for testing. Source packages are not supported at the moment and I did not find a documentation of the architecture "all" and how these packages should be treated.

grafik

@KN4CK3R KN4CK3R added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/packages labels Feb 10, 2023
@KN4CK3R KN4CK3R added this to the 1.20.0 milestone Feb 10, 2023
@KN4CK3R KN4CK3R mentioned this pull request Mar 8, 2023
@codecov-commenter

This comment was marked as off-topic.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 9, 2023
@techknowlogick
Copy link
Member

@KN4CK3R please fix the merge conflicts. 🍵

fixing them now

@techknowlogick techknowlogick enabled auto-merge (squash) April 28, 2023 20:34
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 28, 2023
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look at the code in detail,
here's what I've seen while skimming through it as it seems to get merged soon.

models/migrations/v1_20/v256.go Show resolved Hide resolved
options/locale/locale_en-US.ini Show resolved Hide resolved
debian.registry = Setup this registry from the command line:
debian.registry.info = Choose <code>&lt;distribution&gt;</code> and <code>&lt;component&gt;</code> from the list below.
debian.install = To install the package, run the following command:
debian.documentation = For more information on the Debian registry, see <a target="_blank" rel="noopener noreferrer" href="https://docs.gitea.io/en-us/packages/debian/">the documentation</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even worse, the link is basically deprecated already as the move to .com is already planned…

routers/api/packages/debian/debian.go Show resolved Hide resolved
services/packages/debian/repository.go Show resolved Hide resolved
routers/api/packages/api.go Show resolved Hide resolved
@techknowlogick techknowlogick merged commit bf77e21 into go-gitea:main Apr 28, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 28, 2023
@delvh
Copy link
Member

delvh commented Apr 28, 2023

Erm what?

@delvh
Copy link
Member

delvh commented Apr 28, 2023

Oh.
Apparently it was already scheduled to merge.

yardenshoham added a commit to yardenshoham/gitea that referenced this pull request Apr 28, 2023
techknowlogick pushed a commit that referenced this pull request Apr 28, 2023
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Apr 29, 2023
@silverwind
Copy link
Member

@KN4CK3R sorry we had to revert this because of accidential merge, please raise another PR with discussions resolved, it will be fast-tracked.

@KN4CK3R
Copy link
Member Author

KN4CK3R commented Apr 29, 2023

New PR is #24426.

silverwind pushed a commit that referenced this pull request May 2, 2023
Co-authored-by: @awkwardbunny

This PR adds a Debian package registry.
You can follow [this
tutorial](https://www.baeldung.com/linux/create-debian-package) to build
a *.deb package for testing.
Source packages are not supported at the moment and I did not find
documentation of the architecture "all" and how these packages should be
treated.


![grafik](https://user-images.githubusercontent.com/1666336/218126879-eb80a866-775c-4c8e-8529-5797203a64e6.png)

Part of #20751.

Revised copy of #22854.

---------

Co-authored-by: Brian Hong <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
Co-authored-by: Giteabot <[email protected]>
@lunny lunny removed this from the 1.20.0 milestone May 5, 2023
techknowlogick pushed a commit that referenced this pull request May 5, 2023
Fixes #20751

This PR adds a RPM package registry. You can follow [this
tutorial](https://opensource.com/article/18/9/how-build-rpm-packages) to
build a *.rpm package for testing.

This functionality is similar to the Debian registry (#22854) and
therefore shares some methods. I marked this PR as blocked because it
should be merged after #22854.


![grafik](https://user-images.githubusercontent.com/1666336/223806549-d8784fd9-9d79-46a2-9ae2-f038594f636a.png)
@delvh delvh added this to the 1.20.0 milestone May 6, 2023
silverwind added a commit that referenced this pull request May 12, 2023
This PR adds an Alpine package registry. You can follow [this
tutorial](https://wiki.alpinelinux.org/wiki/Creating_an_Alpine_package)
to build a *.apk package for testing.

This functionality is similar to the Debian registry (#22854) and
therefore shares some methods. I marked this PR as blocked because it
should be merged after #22854.


![grafik](https://user-images.githubusercontent.com/1666336/227779595-b76163aa-eea1-4a79-9583-775c24ad74e8.png)

---------

Co-authored-by: techknowlogick <[email protected]>
Co-authored-by: silverwind <[email protected]>
Co-authored-by: Giteabot <[email protected]>
@delvh delvh removed this from the 1.20.0 milestone May 14, 2023
@delvh delvh added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 14, 2023
@delvh
Copy link
Member

delvh commented May 14, 2023

Had to de-assign the milestone in this case as there's the followup PR that has the same + a bit more that wasn't reverted,
and it looks weird otherwise when there are two Add Debian registry PRs in the changelog.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/packages type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants