Projects: rename Board to Column in interface and improve consistency #22767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I started fixing various capitalization inconsistencies and then noticed the plan in #20985 is to rename boards to columns. So I decided to do that here as well so it matches what we want it to look like in the end. That PR however has been stalled for a bit, and I don't know if it would be acceptable to merge just the interface side renaming or not. |
GiteaBot
added
the
lgtm/need 2
What is called a board now is really a column on a project board. This changes just the naming in the interface and leaves the underlying implementation unchanged. Further this improves consistency of the projects interface in a few ways: * Consistent title case for titles, buttons and menu items * Use just Column instead of Project Column consistently * Fix some wrong plural names * Consistent color of cancel and submit buttons in forms * Fix inconsistent rendering of template field in new project
brechtvl
force-pushed
the
blender-project-ui
branch
from
571bdf2
to
7f3e8d8
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #22767 +/- ##
=======================================
Coverage 47.29% 47.29%
=======================================
Files 1111 1111
Lines 149398 149408 +10
=======================================
+ Hits 70656 70668 +12
- Misses 70350 70354 +4
+ Partials 8392 8386 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lunny
approved these changes
Feb 5, 2023
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Feb 24, 2023
GiteaBot
added
lgtm/done
|
LGTM, could you resolve conflicts? |
|
#20985 sort of does this |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 27, 2023
* giteaofficial/main: Revert "[skip ci] Updated translations via Crowdin" (go-gitea#23167) [skip ci] Updated translations via Crowdin Return 404 instead of 403 if user can not access the repo (go-gitea#23155) [skip ci] Updated licenses and gitignores Fix secrets overview page missing from docs sidebar (go-gitea#23143) Add "Reviewed by you" filter for pull requests (go-gitea#22927) Projects: rename Board to Column in interface and improve consistency (go-gitea#22767) Fix DBConsistency checks on MSSQL (go-gitea#23132) Add pagination for dashboard and user activity feeds (go-gitea#22937) Update go.mod dependencies (go-gitea#23126) Show empty repos in Admin Repository Management page (go-gitea#23114) Redirect to the commit page after applying patch (go-gitea#23056) Bump go.etcd.io/bbolt and blevesearch deps (go-gitea#23062) Fix height for sticky head on large screen on PR page (go-gitea#23111)
lunny
pushed a commit
that referenced
this pull request
Mar 12, 2023
In #22767, we changed the class of `Edit Column` button from `red` to `primary` But `red` is used to find this button in js..... --------- Co-authored-by: techknowlogick <[email protected]> Co-authored-by: zeripath <[email protected]>
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is called a board now is really a column on a project board. This changes just the naming in the interface and leaves the underlying implementation unchanged.
Further this improves consistency of the projects interface in a few ways: