-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More detailed branch delete message #22696
Conversation
I think perhaps this should just be a warning of The proposed change appears even more likely to make people confused. |
What about |
we can load this config value by backend directly, is't it? so I think we can show |
I like that! It gives exact information without disturbing the user with technical details. |
I think it's good to use the most strict warning for end users, do not make users expect some lucky miracle. For example, what about the So I'd like to keep the old wording. Users should keep in mind they shouldn't expect a deleted branch could be recovered. |
I support a strict wording! However, I tiny hint that the repo is scheduled for removal helps understand that it does not disappear immediately... I don't think we need to spend more time for this issue since the gain is minimal. Please accept or reject to your liking. Thanks |
Co-authored-by: wxiaoguang <[email protected]>
Fix #22624 . Message explains that deleted branch can only be restored for a short time period.