Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve checkIfPRContentChanged (#22611) #22644

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Improve checkIfPRContentChanged (#22611) #22644

merged 1 commit into from
Jan 28, 2023

Commits on Jan 28, 2023

  1. Improve checkIfPRContentChanged (go-gitea#22611) 

    Backport go-gitea#22611

The code for checking if a commit has caused a change in a PR is
extremely inefficient and affects the head repository instead of using a
temporary repository.

This PR therefore makes several significant improvements:

* A temporary repo like that used in merging.
* The diff code is then significant improved to use a three-way diff
instead of comparing diffs (possibly binary) line-by-line - in memory...

Ref go-gitea#22578

Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    40c7ea3 View commit details
    Browse the repository at this point in the history