Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the local identifier to the pypi version regex #21684

Closed
wants to merge 1 commit into from
Closed

Add the local identifier to the pypi version regex #21684

wants to merge 1 commit into from

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Nov 4, 2022

This PR addresses #21683 allowing for local version identifiers as described by PEP-0440.

image

(Let me know if more testing is needed, I based this largely off of the changes I saw made here: #21095)

@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality topic/packages labels Nov 4, 2022
@techknowlogick
Copy link
Member

Thanks for this PR, would you be able to add some tests for this? If you need any assistance with figuring out where to add tests please let me know and I'd be happy to help :)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 4, 2022
@techknowlogick techknowlogick added this to the 1.19.0 milestone Nov 4, 2022
@Racer159
Copy link
Contributor Author

Racer159 commented Nov 4, 2022

Will do!

@KN4CK3R
Copy link
Member

KN4CK3R commented Nov 5, 2022

Oh, did not see you added a PR already. I've added #21690 which uses the regex provided by pypa/packaging. This should be more complete (added alpha|beta|pre|preview for example) than the old one I was using.

https://github.com/pypa/packaging/blob/main/packaging/version.py#L113-L142

@Racer159
Copy link
Contributor Author

Racer159 commented Nov 5, 2022

Oh, did not see you added a PR already. I've added #21690 which uses the regex provided by pypa/packaging. This should be more complete (added alpha|beta|pre|preview for example) than the old one I was using.

https://github.com/pypa/packaging/blob/main/packaging/version.py#L113-L142

No problem, I hadn't gotten around to writing tests yet, and yeah that should be more complete.

@Racer159
Copy link
Contributor Author

Racer159 commented Nov 7, 2022

Should this be closed now that #21690 is merged?

@lafriks lafriks closed this Nov 7, 2022
@lunny lunny removed this from the 1.19.0 milestone Feb 22, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. topic/packages type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Racer159 @techknowlogick @KN4CK3R @lunny @lafriks @GiteaBot