-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JS dependencies and misc tweaks #21583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
silverwind
commented
Oct 24, 2022
- Update all JS dependencies to latest version
- Disable two redundant eslint rules
- Adapt stylelint config to codebase
- Regenerate SVGs
- Make file editor spinner "reserve" height so page does not shift
- Tested katex, swagger, monaco
- Update all JS dependencies to latest version - Disable two redundant eslint rules - Adapt stylelint config to codebase - Regenerate SVGs - Make file editor spinner "reserve" height so page does not shift - Tested katex, swagger, monaco
silverwind
added
dependencies
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
labels
Oct 24, 2022
techknowlogick
approved these changes
Oct 24, 2022
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Oct 24, 2022
6543
approved these changes
Oct 25, 2022
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Oct 25, 2022
delvh
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disable two redundant eslint rules
Why redundant?
They are coverered by this rule: no-restricted-syntax: [2, WithStatement, ForInStatement, LabeledStatement] |
Enabled a few more useful eslint rules, no new issues with them. |
6543
approved these changes
Oct 26, 2022
delvh
approved these changes
Oct 26, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 28, 2022
* giteaoffical/main: fix: PR status layout on mobile (go-gitea#21547) Make rss/atom identifier globally unique (go-gitea#21550) Fix UI column width, button overflow Fomantic's grid (go-gitea#21559) Localize time units on activity heatmap (go-gitea#21570) Use right syntax for symbolic-ref command (go-gitea#21577) Update JS dependencies and misc tweaks (go-gitea#21583) Add index for hook_task table (go-gitea#21545) Revert: auto generate INTERNAL_TOKEN (go-gitea#21608)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.