Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS dependencies and misc tweaks #21583

Merged
merged 12 commits into from
Oct 28, 2022
Merged

Conversation

silverwind
Copy link
Member

  • Update all JS dependencies to latest version
  • Disable two redundant eslint rules
  • Adapt stylelint config to codebase
  • Regenerate SVGs
  • Make file editor spinner "reserve" height so page does not shift
  • Tested katex, swagger, monaco

- Update all JS dependencies to latest version
- Disable two redundant eslint rules
- Adapt stylelint config to codebase
- Regenerate SVGs
- Make file editor spinner "reserve" height so page does not shift
- Tested katex, swagger, monaco
@silverwind silverwind added dependencies skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 24, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 24, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 25, 2022
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disable two redundant eslint rules

Why redundant?

@silverwind
Copy link
Member Author

They are coverered by this rule:

  no-restricted-syntax: [2, WithStatement, ForInStatement, LabeledStatement]

@lunny lunny added this to the 1.19.0 milestone Oct 26, 2022
@silverwind
Copy link
Member Author

Enabled a few more useful eslint rules, no new issues with them.

@techknowlogick techknowlogick merged commit b1dd1ba into go-gitea:main Oct 28, 2022
@silverwind silverwind deleted the deps-43 branch October 28, 2022 14:14
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 28, 2022
* giteaoffical/main:
  fix: PR status layout on mobile (go-gitea#21547)
  Make rss/atom identifier globally unique (go-gitea#21550)
  Fix UI column width, button overflow Fomantic's grid (go-gitea#21559)
  Localize time units on activity heatmap (go-gitea#21570)
  Use right syntax for symbolic-ref command (go-gitea#21577)
  Update JS dependencies and misc tweaks (go-gitea#21583)
  Add index for hook_task table (go-gitea#21545)
  Revert: auto generate INTERNAL_TOKEN (go-gitea#21608)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants