Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix button in branch list, avoid unexpected page jump before restore branch actually done #21562

Merged
merged 24 commits into from Nov 24, 2022
Merged

Fix button in branch list, avoid unexpected page jump before restore branch actually done #21562

merged 24 commits into from Nov 24, 2022

Commits on Oct 23, 2022

  1. UI: bug fix, replace html tags <a> with <div> in button: delete branch 

    reason:

- unified code style
- Edge Browser Warning: `Links must have discernible text: Element has no title attribute`
- Using an empty anchor as an HTML tag will point to the current page, which cause the page jump before the execution of JavaScript

Signed-off-by: baronbunny <[email protected]>
    baronbunny committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    4135439 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ui/repo/branch/delete-branch-button

    rock2dust authored Oct 23, 2022
    Configuration menu
    Copy the full SHA
    f957d23 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ui/repo/branch/delete-branch-button

    rock2dust authored Oct 23, 2022
    Configuration menu
    Copy the full SHA
    21c5e53 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. UI: use button tags as buttons in branch view 

    Instead of divs these should be buttons so Screen readers know they are buttons

Signed-off-by: baronbunny <[email protected]>
    baronbunny committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    16e9f4e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ui/repo/branch/delete-branch-button

    rock2dust authored Oct 24, 2022
    Configuration menu
    Copy the full SHA
    f52ac59 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2022

  1. Merge branch 'main' into ui/repo/branch/delete-branch-button

    Xinyu Zhou committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    e31db19 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 15, 2022
    Configuration menu
    Copy the full SHA
    fa1d11e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lafriks
    lafriks authored Nov 15, 2022
    Configuration menu
    Copy the full SHA
    01ef49b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 15, 2022
    Configuration menu
    Copy the full SHA
    52aebb0 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2022

  1. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 19, 2022
    Configuration menu
    Copy the full SHA
    0d7f176 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 19, 2022
    Configuration menu
    Copy the full SHA
    c874fe0 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 21, 2022
    Configuration menu
    Copy the full SHA
    a03ec85 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 21, 2022
    Configuration menu
    Copy the full SHA
    7ffc3b1 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    0e32f1f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    b78b43c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    d42b729 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 23, 2022
    Configuration menu
    Copy the full SHA
    271a742 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 23, 2022
    Configuration menu
    Copy the full SHA
    4c08bc2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 23, 2022
    Configuration menu
    Copy the full SHA
    3cee06e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 23, 2022
    Configuration menu
    Copy the full SHA
    b2e74f8 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 24, 2022
    Configuration menu
    Copy the full SHA
    d798f2a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 24, 2022
    Configuration menu
    Copy the full SHA
    aeb6055 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 24, 2022
    Configuration menu
    Copy the full SHA
    6da4157 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into ui/repo/branch/delete-branch-button

    @lunny
    lunny authored Nov 24, 2022
    Configuration menu
    Copy the full SHA
    57d09da View commit details
    Browse the repository at this point in the history