Fix issues count bug #21557
Merged
Fix issues count bug #21557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/bug
skip-changelog
ghost
reviewed
Oct 23, 2022
GiteaBot
added
the
lgtm/need 2
delvh
reviewed
Oct 23, 2022
|
@delvh done. |
|
It should not be fixed. You have no more tests so that you cannot encounter it. |
delvh
approved these changes
Oct 24, 2022
GiteaBot
added
lgtm/need 1
6543
reviewed
Oct 25, 2022
6543
approved these changes
Oct 25, 2022
GiteaBot
removed
the
lgtm/need 1
GiteaBot
added
the
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 25, 2022
* upstream/main: Fix issues count bug (go-gitea#21557) Improve code comment review on mobile (go-gitea#21461) Consolidate remaining colors into variables (go-gitea#21582)
Merged
Merged
lunny
pushed a commit
that referenced
this pull request
Dec 6, 2022
When deleting a closed issue, we should update both `NumIssues`and `NumClosedIssues`, or `NumOpenIssues`(`= NumIssues -NumClosedIssues`) will be wrong. It's the same for pull requests. Releated to #21557. Alse fixed two harmless problems: - The SQL to check issue/PR total numbers is wrong, that means it will update the numbers even if they are correct. - Replace legacy `num_issues = num_issues + 1` operations with `UpdateRepoIssueNumbers`.
This was referenced Dec 6, 2022
lunny
pushed a commit
that referenced
this pull request
Dec 6, 2022
Backport #22037. When deleting a closed issue, we should update both `NumIssues`and `NumClosedIssues`, or `NumOpenIssues`(`= NumIssues -NumClosedIssues`) will be wrong. It's the same for pull requests. Releated to #21557. Alse fixed two harmless problems: - The SQL to check issue/PR total numbers is wrong, that means it will update the numbers even if they are correct. - Replace legacy `num_issues = num_issues + 1` operations with `UpdateRepoIssueNumbers`.
lunny
added a commit
that referenced
this pull request
Dec 7, 2022
Backport #22037. When deleting a closed issue, we should update both `NumIssues`and `NumClosedIssues`, or `NumOpenIssues`(`= NumIssues -NumClosedIssues`) will be wrong. It's the same for pull requests. Releated to #21557. Alse fixed two harmless problems: - The SQL to check issue/PR total numbers is wrong, that means it will update the numbers even if they are correct. - Replace legacy `num_issues = num_issues + 1` operations with `UpdateRepoIssueNumbers`. Co-authored-by: Lunny Xiao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #19349 , #19505