Use recommended vscode configuration in gitpod environments

[yardenshoham]

To make go tests run in gitpod, the vscode settings.json must be in the correct place in the filesystem

[silverwind]

Why not move it into the correct place? Are the settings in there too opinionated? Note, I'm not a vscode user, so I can't really comment on them.

[yardenshoham]

Why not move it into the correct place? Are the settings in there too opinionated? Note, I'm not a vscode user, so I can't really comment on them.

I'm for placing it at the root

• Previous discussion: Basic VSCode configuration for building and debugging #2483

[wxiaoguang]

Why not move it into the correct place? Are the settings in there too opinionated? Note, I'm not a vscode user, so I can't really comment on them.

I am against for putting the .vscode in the root. These settings don't satisfy everyone, some people may want to change these settings. If the .vscode is put in the root, then how could they handle these changed files when committing?

[yardenshoham]

These settings are project-specific, any user settings are in another file. Having this at the root helps vscode users and hurts no one. I can't think of any project-specific setting vscode users have that shouldn't be committed.

[wxiaoguang]

These settings are project-specific, any user settings are in another file. Having this at the root helps vscode users and hurts no one. I can't think of any project-specific setting vscode users have that shouldn't be committed.

But what if some people modified launch.json with other commands or changed the go.buildTags in settings.json?

And this comment: #2483 (comment)

[yardenshoham]

Then they probably did it for good reason and should commit the modification

[wxiaoguang]

Then they probably did it for good reason and should commit the modification

I do not think so. When I am using VSCode, sometimes I add temporary options for my local debug purpose.

[yardenshoham]

If it's temporary, then you would simply not commit it

[wxiaoguang]

Then I have to manually deselect them when committing 😂 again and again.

So, leave an empty .vscode and prepare it for everyone locally is the most clear solution IMO.

[yardenshoham]

Then I have to manually deselect them when committing 😂 again and again.

How is that any different than not committing say, debug log statements?

[wxiaoguang]

• .vscode in root: ignore them from time to time if there are local changes.
• vscode in contrib: only copy the directory when first setup if you need (the new developer should have spent enough time on reading the development guideline, a copy won't take too much time), then change it freely as you want. No need to spend more time on it.

---

• debug log statements: sometimes they can be avoided. If they can not be avoided, then the time can not be saved.

[silverwind]

It's an improvement in any case.