-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set SemverCompatible to false for Conan packages (#21275) #21366
Conversation
Backported migration will break the new releases. |
You are right, how to handle that? |
No idea .... there was an old PR for backport migration (#10625) but no progress. I wasn't a member at that time. |
So in essence, the migration system can not detect whether a certain migration, identified by a string, has already ran and skip it? I think the numbering scheme would have to be dropped to make it more smart then. |
No at the moment. The Gitea's migration system is quite tricky and needs to be improved IMO. For this backport, maybe the migration can be dropped, and tell users to run a SQL manually if they encounter the bug (very few), or provide temporary doctor command (although I prefer to avoid too many doctor commands). |
The migration could be run multiple times in this case but yes, the "index" 224 would be marked as "already run" and the real 224 from Gitea 1.18 would be skipped. |
Fixes go-gitea#21250 Related go-gitea#20414 Conan packages don't have to follow SemVer. The migration fixes the setting for all existing Conan and Generic (go-gitea#20414) packages.
…o backport-30ca916
0ad45c2
to
bccb546
Compare
Not a solution for this PR, but something to keep in mind for the 1.19 dev cycle: |
For future improvement to the migration system, I would suggest using a set of unique strings that identify migrations, ideally inserted into a separate table once ran. That way, all the number collision problems go away as well. Thought generally I would expect the ORM to handle migrations transparently and in simple cases like column addition or type changes, automatically. |
Backport of #21275